testr can have confusing behaviour when a test id is repeated during a stream given to testr load
Bug #620388 reported by
Brad Crittenden
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Testrepository |
Triaged
|
Wishlist
|
Unassigned |
Bug Description
The attached log file is a value subunit stream which 'testr load' identifies as having one failure, but 'testr failing' does not show the failure afterwards.
The cause of this is this:
subunit-ls < .testrepository/0 | grep distribution_txt
distribution_txt
distribution_txt
The test id is being reused and test ids are treated as primary keys.
There are a few options that testr can do better at:
- it could warn on duplicate test ids (they are generally bad)
- it could add a unique prefix/suffix for its own handling but still use the original when running test commands.
- ???
Of the three warning is easiest and possibly sufficient.
summary: |
- testr lies with some ec2 log files + sometimes testr does not record failure in .testrepository/failing |
summary: |
- sometimes testr does not record failure in .testrepository/failing + sometimes testr does not record failure in .testrepository/failing when + test id is reused |
description: | updated |
summary: |
- sometimes testr does not record failure in .testrepository/failing when - test id is reused + testr should warn when a test id is repeated in a load operation |
summary: |
- testr should warn when a test id is repeated in a load operation + testr can have confusing behaviour when a test id is repeated during a + stream given to testr load |
description: | updated |
description: | updated |
Changed in testrepository: | |
status: | Incomplete → Confirmed |
Changed in testrepository: | |
status: | Confirmed → Triaged |
importance: | Undecided → Wishlist |
To post a comment you must log in.
Works for me - the load line shows:
....
ZopelessLayer. testSetUp 2445 calls taking 1.9s. testTearDown 2445 calls taking negligible time.
ZopelessLayer.
Total duration of profiled methods 2284.9 seconds.
Total duration of test run 12725.0 seconds.
Tests failed (exit code 1) ======= ======= ======= ======= ======= ======= ======= ======= ======= ------- ------- ------- ------- ------- ------- ------- ------- ------- python2. 6/unittest. py", line 279, in run python2. 6/doctest. py", line 2152, in runTest eption( self.format_ failure( new.getvalue( ))) soyuz/tests/ ../doc/ distribution. txt", line 0
make: *** [check] Error 1
=======
FAIL: distribution_txt
-------
Text attachment: traceback
------------
Traceback (most recent call last):
File "/usr/lib/
testMethod()
File "/usr/lib/
raise self.failureExc
AssertionError: Failed doctest test for distribution.txt
File "lib/lp/
------- ------- ------- ------- ------- ------- ------- ------- ------- ------- soyuz/tests/ ../doc/ distribution. txt", line 86, in distribution.txt newSeries( 'gentoo- two', 'Gentoo Two',
'Gentoo Two Dot Oh', 'Gentoo 2', 'G2',
'2.0', None, gentoo.owner) python2. 6/doctest. py", line 1248, in __run txt[19] >", line 1, in <module> newSeries( 'gentoo- two', 'Gentoo Two', Moderate' )
File "lib/lp/
Failed example:
gentoo.
Differences (ndiff with -expected +actual):
Traceback (most recent call last):
- ...
+ File "/usr/lib/
+ compileflags, 1) in test.globs
+ File "<doctest distribution.
+ gentoo.
- Unauthorized: (<Distribution...>, 'newSeries', 'launchpad.Append')
? ^^^ ^^^ ^^
+ Unauthorized: (<Distribution 'Gentoo' (gentoo)>, 'newSeries', 'launchpad.
? ^^^^^^^^^^^^^^^^^^ ^^^ ^^^^
------------
id: 0 tests: 9540 failures: 1 skips: 23