--subunit makes --until-failure not actually work

Bug #1411804 reported by Sean Dague on 2015-01-16
This bug affects 3 people
Affects Status Importance Assigned to Milestone

Bug Description

If you specify the --subunit flag to testr run, --until-failure no longer fails correctly.

This can be reproduced with a trivial case of:


in some test, then

testr run --subunit --until-failure that_test_name

It will loop forever with no stopping.

Matthew Treinish (treinish) wrote :

I was playing with the --subunit flag a bit today and found that using --subunit means that testr is always returning 0 even during failure. I was going to file a separate bug for that, but I expect that these 2 issues are in fact the same.

Robert Collins (lifeless) wrote :

--subunit should always return 0, because the intent of --subunit is that you're doing your own porcelain {it will return non-zero on stream generation failure}.

--until-failure is awkward, but I think making it loop sanely with --subunit is better than making the options incompatible with each other.

Changed in testrepository:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers