SIGINT during test run leads to uneven test distribution on future runs

Bug #1322763 reported by Andrew Laski on 2014-05-23
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Testrepository
High
Robert Collins

Bug Description

If a testr run is interrupted it records a test time of 0 for tests that didn't run. This causes issues when tests are being grouped for parallel runs since all of the 0 run time tests end up grouped into the same bucket which can grow disproportionately large. An example split I've seen is 14 14 10600 13 for concurrency 4.

Robert Collins (lifeless) wrote :

Oh nice catch, we should be not doing that.

Changed in testrepository:
assignee: nobody → Robert Collins (lifeless)
milestone: none → next
status: New → Fix Committed
importance: Undecided → High
tags: added: regression
Changed in testrepository:
status: Fix Committed → Fix Released
Corey Wright (coreywright) wrote :

note: .testrepository/times.dbm needs to be deleted if created by an incomplete test run with < 0.0.19.

what i comprehend from the code change (commit 87e0de0) and validated through testing...

the change directly affects the writing of the database and indirectly the running of the tests, so if a database was written with < 0.0.19 during an interrupted test run, then the problem will still exhibit itself even after an upgrade as the "invalid" data will still be read from the database by 0.0.19. (not to be misinterpreted as me suggesting testrepository should start versioning and upgrading its database.)

Corey Wright (coreywright) wrote :

@Robert Collins

thanks for the fix!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers