CTRL+} and CTRL+{ do not work as keybindings

[Aengus Walton]

The common next-tab / prev-tab keybindings CTRL+} and CTRL+{ do not work.

Steps required to reproduce:
1. Set "Next tab" keybinding to CTRL+}. That is, hold control, shift and press ']'.
2. Try to use the keybinding. It won't work.

[Thomas Hurst (tom.hurst)]

Confirmed, thanks. The bindings are being set as "<Shift><Control>{" in the prefs dialog, when the keybinding code is expecting "<Control>braceleft". This might have been a little more obvious if the keybinding parse errors weren't being silently discarded.

In the absence of a fix, these keys can be set manually by editing the config file by hand (see the terminator_config manpage).

[Chris Jones (cmsj)]

Hi

On 15/05/12 21:34, Thomas Hurst wrote:
> "<Control>braceleft". This might have been a little more obvious if the
> keybinding parse errors weren't being silently discarded.
This definitely seems worth fixing. Do you happen to know where we are
discarding these? (presumably an overzealous exception catcher?)

Cheers,
Chris

[Thomas Hurst (tom.hurst)]

Yup, keybindings.py:82. I've pushed a fix.

[David Futcher (bobbo)]

Using <Control><Shift> { , } and : all appear to be broken (probably amongst others, those are the three I tried) in current bzr trunk.

[Stephen Boddy (stephen-j-boddy)]

Hi Bug subscribers, this is the maintainer (Steve Boddy) of Terminator, who took over from Chris.

In case you were not aware there has been a new release 0.98 of Terminator in the last few days which has many changes, fixes and updates. We also have an ongoing GTK3 port which uses a much more up-to-date libvte.

Even with the ~50 issues closed by that release, and discounting the ~90 outstanding wishlist items, we still have an unwieldy 95 bugs. With the oldest approaching it's 6th birthday and some that haven't seen any updates in nearly 5, it is time for a purge.

My intention is to try and get this list down to a minimum, and for that I need your help.

First I'm going to work through, oldest to newest, setting bugs to Incomplete, pending confirmation that they are still an issue. If after a month there is no feedback, the issue will get closed as Invalid. Here's where you come in. I can't always reproduce, or setting up (i.e. other distros) to even test takes a long time, so I'm going to try crowdsourcing this.

1. Get the latest release. Is it still an issue? If yes, set the confirmed-0.98 tag. For bonus points follow the guide http://gnometerminator.blogspot.com/2015/09/so-you-want-to-try-terminator-gtk3.html and see if the GTK3 branch has same issue, and set the confirmed-gtk3 or notaffected-gtk3 tag.

2. Can you reproduce with an empty/default config file? You can pass "-g temp_config" to do this without affecting your existing config. If you already have Terminator running, you'll need to pass -u as well to disable the DBus.

3. If able to, can you reproduce with another user/guest account?

4. If the issue does not already have clear, precise instructions to reproduce with minimal setup/steps, add them.

5. Put as much info about what you are running.
   * Software/library versions (libvte, gtk, pango, cairo, distro, desktop environment, language)
   * Screens (single or multi)
   * Any unusual / custom packages or configs that might be interacting.

6. If possible attach the config file, unless the issue also happens with an empty one, but mention that.

7. Attach the "-d" debug output from 0.98.

Some common things that cause incidents.

* Strange sizing issues or rapidly shrinking windows - Try turning off Window geometry hints.
* Input (esp. broadcasting duplicate chars etc) problems - Try killing IBus.
* Hand editing of the config file can cause various issues - Due to misunderstanding, incorrect structure or typos.
* Some issues are actually in libvte - This is why testing GTK3 is so important.
* segfaults - Unfortunately these are dying inside the C libraries, and it is usually beyond me to fix those.

Many thanks for your assistance, and hopefully this will get us closer to a bug-free Terminator.

[Stephen Boddy (stephen-j-boddy)]

OK, a little info: The binding is being set as <Shift><Ctrl>{

If I edit the config file manually, and remove the shift modifier then the binding works. The keybinding stuff does a few funky looking things, so it looks like we're probably misinterpreting the keypress in the prefs window when we try to set it.

[Stephen Boddy (stephen-j-boddy)]

Committed revision 1709.

Not 100% sure why this works, but I'm not complaining :-) Hopefully doesn't break things elsewhere.

[Stephen Boddy (stephen-j-boddy)]

OK, So that didn't work. It had the unintended side effect of causing Ctrl+PgDn to *move* the tab instead of select the next one. (Reported by a user directly to me) Reopening this ticket for now until I can figure out a better fix.

[Stephen Boddy (stephen-j-boddy)]

With the 1709 change Ctrl+Left is also detected as Ctrl+Shift+Left which is the splitter resize shortcut.

[Stephen Boddy (stephen-j-boddy)]

Reverting 1709 as other bugs are being raised.