Simultaneous typing in multiple grouped terminals send all the output to one terminal

Bug #314233 reported by Volans
10
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Undecided
Unassigned

Bug Description

As suggested here ( https://bugs.launchpad.net/terminator/+bug/246297/comments/32 ) I report this bug as a new bug.

Step to reproduce:
- open terminator
- split terminal with ctrl+o or ctrl+e (one or multiple times)
- mouse right click to show the menu, select Group -> Group All (or Group any number of terminal just splitted)
- write something to the focused terminal

What should happen:
the text and command typed will simultaneously appear in all the grouped terminals

What happen to me:
- in the focused terminal every pressed key appers N times where N is the number of the grouped terminals, so if I have grouped 3 terminals and I press "c" I see "ccc" in the focused terminal, nothing in the others.
- in the other grouped terminals nothing happens
- commands like "Enter" or "ctrl+l" (clear screen), etc... sent to the focused terminal are correctly reproduced into all the grouped terminals

It seems that the text input is sent the right number of times but all to the same terminal instead of being splitted into the grouped terminals.

See also the attached image.

OS: Ubuntu 8.10 Intrepid Ibex 64bit
Kernel: 2.6.27-9-generic
Terminator version: 0.12 (bzr revision 630)

Related branches

Revision history for this message
Volans (volans) wrote :
Revision history for this message
Chris Jones (cmsj) wrote :

I am entirely unable to reproduce this, so I think we need to have some more debugging so the problem can be revealed.

Changed in terminator:
milestone: none → 0.12
Revision history for this message
Volans (volans) wrote :

Chris, I have sent to you an email about this bug some days ago (01/07/2009 00:07 CEST). Feel free to ask me what do you need in order to understand the problem.

Maybe I have some python plugin installed that conflicts or some other missing package.

Revision history for this message
Chris Jones (cmsj) wrote :

Would you be able to apply the attached patch to current trunk (revision 640) and paste the output here when you type a few characters?

Changed in terminator:
status: New → Incomplete
Revision history for this message
Chris Jones (cmsj) wrote :

Updated patch with more debugging

Revision history for this message
Chris Jones (cmsj) wrote :

I just made an interesting change to trunk which may have some impact on this bug. I'm not sure that it will, but it would be interesting to find out if it's helped at all.

Revision history for this message
enguerran (enguerrangillet) wrote :

Same bug for me on
Ubuntu Jaunty 32 bits
kernel 2.6.28-11-generic
terminator : 0.12-2

Revision history for this message
Chris Jones (cmsj) wrote :

enguerran: could you please try terminator from trunk to see if the issue remains?

bzr branch lp:terminator
cd terminator
./terminator

Revision history for this message
enguerran (enguerrangillet) wrote :

Sorry for the late reply, I forgot to suscribe to this bug.

I just tried with terminator from trunk (revision 735) and the problem remains.

Revision history for this message
Chris Jones (cmsj) wrote :

Hmm, how annoying. It's also annoying that I can't reproduce this myself! Thanks for the report though.

Changed in terminator:
status: Incomplete → Confirmed
Revision history for this message
enguerran (enguerrangillet) wrote :

Is there any log file I can provide ?

Revision history for this message
Osama (osama-m-r) wrote :

Hi Chris,

I've the same problem, although I tried every thing including reinstalling terminator several times.
so have you provided any solutions yet?

If there is any thing I can provide to help fixing this bug, I'll be glad to help.

Thanks

Revision history for this message
Osama (osama-m-r) wrote :

Any news .... ?!!

Revision history for this message
Chris Jones (cmsj) wrote :

Osama: which version are you using?

Revision history for this message
Chris Jones (cmsj) wrote :

Could anyone experiencing this bug please do the following:

1) download the "emitbug.diff" attached to this comment
2) bzr branch lp:terminator
3) cd terminator
4) patch -p0 /path/to/emitbug.diff
5) ./terminator
6) make a few splits
7) group some terminals together (note that in the current bzr code the grouping stuff has moved from the context menu to an icon on the titlebar of each terminal)
8) reproduce the bug
9
) quit terminator
10) attach the debugging output to this bug

I have never been able to reproduce this bug, so without this kind of debugging information it's going to be really hard to fix. Thanks!

Revision history for this message
Chris Jones (cmsj) wrote :

Gah, sorry, step 4 should be:

4) patch -p0 </path/to/emitbug.diff

Revision history for this message
Ahmad Amr (aamr) wrote :

I really don't understand how to do the above points!! Isn't there any easier method??

Revision history for this message
Osama (osama-m-r) wrote :

Hi Chris,

I'm trying to do the above steps, but I've a problem with "bzr" (bzr: ERROR: socket.error: (113, 'No route to host') ) , I'll try to fix it and proceed.

btw ... I'm using version 0.13

Thanks

Revision history for this message
Chris Jones (cmsj) wrote :

I've attached a tarball to this comment which contains a pre-patched source tree, so the steps would be:

1) download the tarball
2) tar -xvzf /path/to/terminator-test.tar.gz
3) cd terminator-test
4) ./terminator
5) make a few splits
6) group some terminals together (again noting that the group controls are now in the titlebar, not the right click menu)
7) reproduce this bug
8
) quit terminator
9) attach the debugging output to this bug

Revision history for this message
Osama (osama-m-r) wrote :

Hi Chris,

This is the only output I'm getting (when clicking group icon in title bar):

Traceback (most recent call last):
  File "/home/osama/Desktop/terminator-test/terminatorlib/terminatorterm.py", line 1478, in position_popup_group_menu
    widget_win = widget.get_window()
AttributeError: 'gtk.EventBox' object has no attribute 'get_window'

I don't know if this helps or not.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

@ Osama - it looks like your PyGTK is a bit old, and the get_window method is not available.

@ Chris - Sorry, looks like some of my group code is depending on a recent (2.14+) version of PyGTK. This was only added in Jaunty. Intrepid was on 2.13.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

@ Osama - In the downloaded code, in the terminatorlib/terminatorterm.py file, find the line:

menu.popup (None, None, self.position_popup_group_menu, button, time, widget)

and change it to:

menu.popup (None, None, None, button, time, widget)

This will not solve the original issue, but will allow you to proceed with the actions in #19 from Chris.

Revision history for this message
chantra (chantra) wrote :

I have been working on a python 2.12 compatible branch. It can be found at https://code.edge.launchpad.net/~chantra/terminator/python2.12-compat

mind that assigning to group is now accessed by left-clicking on the left hand side icon within the titlebar.

On the other hand, I could not reproduce on intrepid the original issue of this bug report using trunk (typing going N times into the same terminal), so it might have been fixed earlier on.

Revision history for this message
Osama (osama-m-r) wrote :

Hi Stephen,

I changed that line in as you said, now I get another log (attached).

I wish it helps.

Revision history for this message
Osama (osama-m-r) wrote :

Hi Stephen,

I changed that line in terminatorterm.py as you said, now I get another log (attached).

I wish it helps.

Revision history for this message
Osama (osama-m-r) wrote :

I forgot to mention something:

This error appeared when I typed one character, while the group consists of four terminals.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Hi Osama,

That's real strange. From the log you attach the code looks to do the correct thing. Edit the file terminatorlib/terminator.py and goto lin 1505, change it from:
    print "group_emit: test matched. emitting event"
to:
    print "group_emit: test matched. emitting event to %s" % (term._vte)
and rerun the test.

Unless terminator is somehow confusing the VTE's, then this would mean the problem is in the python bindings to the vte library or the library itself. You could add the output of:
    dpkg -l | grep vte
as well. This may (or may not) help.

Revision history for this message
Osama (osama-m-r) wrote :

Hi Stephen,
I ran the test again, and the vte check as well.

Please check attachment.

Thanks

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

OK, from that it is definitely different vte's that are getting the emit, so I'd have to assume that the problem is in the libraries somehow. You have version 0.17 of the vte stuff which would put you on 8.10 - intrepid (I'm on jaunty with version 0.20) so it may be something fixed since.

The only thing I can think of is for you to try updating libvte and python-vte to 0.20. I'm not sure if they are available for intrepid, or if you can force them in from jaunty (i.e. that might break something else.)

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

If you're brave:
https://launchpad.net/ubuntu/+source/vte/1:0.20.0-0ubuntu2/+build/922129

Download the set of *.deb files from there into a new folder (in theory you'll get away with libvte-common, libvte9, and python-vte, as they're the only ones I have installed.) Open a terminal and cd to that new folder. then do:
    sudo dpkg -i *.deb
enter your password, then pray.
If it complains or tries to remove a bunch of stuff, then it looks like you're out of luck. If it all installs you should in theory be able to start the terminal again, and see if the grouping now works.

Revision history for this message
Chris Jones (cmsj) wrote :

We're almost a year on from the version of Ubuntu originally reported to have this bug - is anyone able to reproduce it in Karmic (9.10)?

Changed in terminator:
status: Confirmed → Incomplete
Revision history for this message
enguerran (enguerrangillet) wrote :

I justed tested it on the Karmic daily build of 05/10/2009 and I don't have this bug anymore :)

Revision history for this message
Chris Jones (cmsj) wrote :

I'm going to mark this as Fix Released. If anyone can still reproduce this, please please please let us know!

Changed in terminator:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.