app does not theme for HCLPI

[patrickw]

(Using Gnome)

Change the gnome appearance to the HCLPI theme (high contrast large print inverse), for accessibility users.

- The terminator does not really theme at all. The terminal tabs do not change foreground or background colour.

- There is no HCLPI version of the terminator app icon (seen through the launch menu).

[Chris Jones (cmsj)]

I'm surprised the tabs don't change, they should inherit the gtk theme.
I definitely want to do as much as we can to support HCLPI, but I will probably need some advice/help from someone who knows the best things to do to make it work. Is that something you would be able to do?

[lee.crabtree (lee-crabtree)]

I just pushed a branch that has one element of this fixed, that being the app icon displayed in the list of active applications (I'm not sure what the official term is). It's a really simple change (just one line!), and it's been working just fine for me for several days now, although I warrant that that isn't really a reasonable amount of testing.

As this is my first real contribution to any kind of open source project AND my first use of Launchpad, I have no idea if there's something I need to do to make my code more easily seen/included, so just say the word if I've missed some part of the process. And thanks for making terminator!

[Stephen Boddy (stephen-j-boddy)]

Hi Lee, the way to get your code "seen" is to "Propose for merging" on the branches launchpad page.

[Stephen Boddy (stephen-j-boddy)]

Lee, should also mention to include steps to show how to confirm. I'm guessing, that I have to create a special icon (where?) set my system to HCLPI (how?) then what? The icon in the taskbar?

[lee.crabtree (lee-crabtree)]

I didn't actually create this bug, so I don't know if my experience was the same as patrickw's, but all I had to do was put terminator on the taskbar, then change the GTK icon theme, and watch the terminator icon stay the same.

[Stephen Boddy (stephen-j-boddy)]

See rev 1585 for changes for this bug.

From OP:
--8<--
Change the gnome appearance to the HCLPI theme (high contrast large print inverse), for accessibility users.

- The terminator does not really theme at all. The terminal tabs do not change foreground or background colour.
[SJB] This bug is really old, and from everything I tried we are theming when switching to HighContrast (prefs, tabs, menus, etc). If the profile colors are set to use colors from system theme, then the terminal itself will switch to black on white.

- There is no HCLPI version of the terminator app icon (seen through the launch menu).
[SJB] Added a whole bunch of high contrast icons for application window, and in-app buttons.
--8<--

We are also now setting the main app icon in a way which will use a properly themed icon. The additional windows need their icons fixing still (prefs, custom commands, layout launcher)

[Stephen Boddy (stephen-j-boddy)]

See rev 1586 for fix to other windows icon settings.

Marking as Fix Committed now.