No <alt>[1-9] key bindings for tab switching (as per gnome-terminal)

[Richard Khoury]

Sorry guys for my laziness, but I couldn't figure out how to branch and push my own changes using bzr (spent over an hour trying and kept getting strange errors). I figured if I submit the patches here you could deal with them as required.

In any case, these patches will allow you to switch tabs via the <alt>[1-9] key combinations in the same way gnome-terminal and firefox works. This is something I really missed having moved from gnome-terminal to terminator.

Two patches to follow...

[Richard Khoury (richiek)]

Second patch...

[Chris Jones (cmsj)]

Thanks for the patch, although I rather think that this should be implemented via the existing keybindings support we have.
I am in two minds about what the defaults should be though - I have always found the alt-1 default of gnome-terminal to be hugely irritating because it clashes with irssi.

[Richard Khoury (richiek)]

If I changed this to be <alt>/<ctr>(/<win-key>?) selectable via the config file (or even switched off altogether) would that be considered more useful?

[Richard Khoury (richiek)]

Check it the fix attached and update this bug-report if any problems exist.

[Chris Jones (cmsj)]

I'm unsetting the Fix Committed status on this, just because we use that to mean committed to trunk. I'll review the merge proposal.

[Richard Khoury (richiek)]

Cool. Be sure to lay any criticisms on me as thick as necessary. I'm only fresh to this project (and haven't done any python programming before) so I'm not used to the protocols/procedures you have in place.

[Jamu Kakar (jkakar)]

I happened to implement the fix for this before noticing this bug
report or Richard's prior work. I've attached the branch with my
changes in case there's something useful there that can be merged in
with what's already in progress.

Also, for what it's worth, this is a must-have feature for me.
While it isn't available, I'll maintain my own branch to play with
Terminator (I implemented this feature after using it for two
minutes and realized I couldn't use it without Alt-Num). I would
expect a lot of people rely on Alt-Num and would be turned off to
find Terminator lacking this behaviour by default. It's a common
idiom used by Firefox, GNOME Terminal, Gwibber and X-Chat GNOME.

[Thomas Hurst (tom.hurst)]

I've merged Jamu's branch, with minor changes to the keybinding names (to match gnome-terminal). Since it's bit of a bikeshed issue, they're unbound by default; if we can work out a way to turn <Alt><Shift>1 into <Alt>! or whatever, I'd be open to having those as default.

[Jamu Kakar (jkakar)]

I've merged trunk, with Thomas's changes, and included more changes
that make it possible to set the accelerator key directly in the
Preference dialog.

[Richard Khoury (richiek)]

I'm really glad to see this feature finally getting merged into trunk.
Many thanks for all those who helped!