URL highlighting broken with VTE 0.60
Bug #1867746 reported by
Egmont Koblinger
This bug affects 8 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Terminator |
Fix Released
|
Critical
|
Bryce Harrington | ||
terminator (Debian) |
Fix Released
|
Unknown
|
|||
terminator (Ubuntu) |
Fix Released
|
High
|
Brian Murray |
Bug Description
Terminator uses old, long-deprecated API to set up the URL regular expressions. This old API stopped working with VTE 0.60. Terminator should switch to the new API.
Related branches
Changed in terminator: | |
status: | New → Triaged |
importance: | Undecided → Critical |
Changed in terminator (Ubuntu): | |
assignee: | nobody → Brian Murray (brian-murray) |
status: | New → In Progress |
importance: | Undecided → High |
Changed in terminator: | |
assignee: | nobody → Bryce Harrington (bryce) |
Changed in terminator (Debian): | |
status: | Unknown → Fix Released |
To post a comment you must log in.
I'm totally unfamiliar with any of the vte code in terminator, and not familiar with vte at all.
However, simple grepping on the deprecated API suggests that these calls:
./terminal.py: self.matches[ 'full_uri' ] = self.vte. match_add_ gregex( reg, 0) 'voip'] = self.vte. match_add_ gregex( reg, 0) 'addr_only' ] = self.vte. match_add_ gregex( reg, 0) 'email' ] = self.vte. match_add_ gregex( reg, 0) 'nntp'] = self.vte. match_add_ gregex( reg, 0) match_add_ gregex( reg, 0) match_add_ gregex( reg, 0) search_ set_gregex( self.searchre, 0)
./terminal.py: self.matches[
./terminal.py: self.matches[
./terminal.py: self.matches[
./terminal.py: self.matches[
./terminal.py: self.matches[name] = self.vte.
./terminal.py: self.matches[name] = self.vte.
./searchbar.py: self.vte.
Probably need to be replaced with the equivalent calls of the form:
self.vte. regex_new_ for_match( reg, ...)
Need to lookup the python3 vte bindings and see exactly what the corresponding python call signature should be. I.e. what is needed for the '...' part, if any?