Bold attribute trimmed out.

Bug #1755498 reported by Marcin Konarski
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Terminator
New
Undecided
Unassigned

Bug Description

It looks like after recent update terminator trims out bold attribute.

I use bold-color feature in my terminal emulators and terminal multiplexers.
Bold-color feature when enabled allows terminals to display characters with set `bold` attribute with user defined color, e.g.: my xterm, my GNUscreen and my tmux are configured to display bold characters as bright yellow color.

This feature is useful, among other things, for reading manual pages, as they use bold (and underline) attributes for visual indicators.

Up til recent terminator update this feature worked in both GNUscreen and tmux when started in terminator, more over, even plain terminator terminal (without terminal multiplexer) displayed nice bright white color for bold attribute.

I have "allow bold text" disabled, enabling it just makes text with bold attribute on displayed with bold face font which is useless for me.

Steps to reproduce:

Run terminator with "allow bold text" off,
in terminal run some terminal multiplexer with bold-color feature configured, in this terminal multiplexer run:
    echo "`tput bold`aaaaa`tput sgr0`"

Actual output:
plain text: aaaaa
Expected output:
bold-color: aaaaa

As a separate issue, terminator could start formally supporting bold-color (and underline-color for good measure) feature by itself.

description: updated
description: updated
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

> even plain terminator terminal (without terminal multiplexer)
> displayed nice bright white color for bold attribute.

This was an intentional change in VTE (libvte-2.91-0; the terminal emulation widget behind Terminator and many others) version 0.51.92, as part of an ongoing attempt to separate the color itself from other attributes (such as boldness) as much as possible. See the commit at
  https://git.gnome.org/browse/vte/commit/?id=e9989360b
and the two addressed bugs mentioned in the commit log:
  https://bugzilla.gnome.org/show_bug.cgi?id=728600
  https://bugzilla.gnome.org/show_bug.cgi?id=793152

VTE has for as long as I can recall supported an API to set bold color. If you wish to have a brighter white than the default for bold text, you should select white as the bold color. The problem is that...

> As a separate issue, terminator could start formally supporting bold-color

... as opposed to let's say GNOME Terminal, Terminator doesn't have such a config option, which you would need now. So it's not a separate issue.

> (and underline-color for good measure)

And then a corresponding "allow underline", and then the same for italic, for double underline, for curly underline, for strikethrough, and for all combinations of these... nope, VTE doesn't support these, and we're not planning to start moving in this direction. (One possibility pending for VTE, however, is to have an API where the terminal emulator can register a callback to arbitrarily mangle the colors and attributes of cells before displaying them, this would cover all these cases.)

> in terminal run some terminal multiplexer with bold-color feature configured,

I'm not sure if the above explanation properly covers your issue with multiplexer involved, and you no longer seeing your preferred bright yellow letters (or do I understand it correctly that it also stopped working?). Could you please elaborate: How do you exactly configure screen or tmux to reproduce this?

Quick summary so far: Terminator should add a "bold color" option.

Revision history for this message
Marcin Konarski (marcin-konarski+u1) wrote :

Yes, you are completely right.

I am sorry for the noise but I completely mixed up how my configuration actually works.

I have both GNUscreen and tmux configured for "pass-through" on bold attribute and swap for bright magenta for underline attribute, that is why handling underline still works when I have my terminal multiplexers running.
I guess I should configure them now to handle bold attribute too.

Still explicit bold-color would be a nice feature in terminator though I understand that it will probably not happen.

It looks like this is duplicate of #1378210 issue then.

I am really sorry for the noise.
Thank you for your assistance.

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

> [...] though I understand that it will probably not happen.

Why not? I think it's a fair request, and the aforementioned VTE change puts a bit more pressure on Terminator to implement this. (For the record: I'm not Terminator's developer.)

I'm actually also thinking about addressing https://bugzilla.gnome.org/show_bug.cgi?id=722751 so that you can specify the bold color in VTE using escape sequences, to work around if the VTE-based app doesn't have this option.

> It looks like this is duplicate of #1378210 issue then.

Indeed.

> I am really sorry for the noise.

No no, don't be sorry, this was a pretty good report, thanks!

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Forthcoming vte-0.52.1 adds support for changing the bold color via escape sequence, e.g.:

echo -ne '\e]5;0;#ffffff\a'

Revision history for this message
Marcin Konarski (marcin-konarski+u1) wrote :

That is great news! Thanks!

Revision history for this message
XANi (xani666) wrote :

Maybe set (or allow as an option) "bold is bright" in vte

That is what mate-terminal ( https://github.com/mate-desktop/mate-terminal/issues/278 ) and asbru-cm ( https://github.com/asbru-cm/asbru-cm/issues/210 ) did

Revision history for this message
XANi (xani666) wrote :

Temporary fix: add

        self.vte.set_bold_is_bright(True)

after "self.vte.set_allow_bold(self.config['allow_bold'])" (~line 670) in terminal.py

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.