Closing pane leaves area blank

[Julien Nicoulaud]

Environment:
 - CentOS 6.x
 - GNOME 2.31
 - Bash 4.1.2 and Zsh 4.3.10
 - Terminator trunk, rev 1761

Steps to reproduce:
 - CTRL+SHIFT+E to split terminal
 - CTRL+D to close panes
 - Instead of reallocating space, the closed panes are left blank

See screencast: https://gfycat.com/WatchfulUnluckyFlyingfox

The debug log contains:

Traceback (most recent call last):
  File "/data/home/jnicoulaud/work/terminator/terminatorlib/paned.py", line 278, in wrapcloseterm
    metadata = parent.get_child_metadata(self)
  File "/data/home/jnicoulaud/work/terminator/terminatorlib/paned.py", line 245, in get_child_metadata
    metadata['had_focus'] = widget.has_focus()
AttributeError: 'HPaned' object has no attribute 'has_focus'

Full debug log: http://pastebin.com/raw/1bjWrjBj

[Stephen Boddy (stephen-j-boddy)]

"GNOME 2.31" - Are you sure about that version? Looking at https://developer.gnome.org/gtk2/ they list the current/latest version as 2.24.31.

However the error message you see I cannot reproduce. It also makes no sense, as the HPaned object inherits from Widget (via the hierarchy you can see here: https://developer.gnome.org/gtk2/stable/GtkHPaned.html , and the inheritance/mix-in class seen in the terminatorlib/paned.py file).

The common Widget class is the one that provides the has_focus method, so it should be there.

[Stephen Boddy (stephen-j-boddy)]

Please note that I'm not really doing anything with the gtk2 version of terminator anymore, only the gtk3 version. Can you reproduce this with that version?