Hi Wesley. Definitely something I think would be an interesting addition. Obviously I don't know how you've implemented this, so I'd have to see the code to give more thoughts or opinions. Just a few quick thoughts that occur to me:
Does this only match output, or input too? i.e. Can I sound a big siren if I type "rm -rf" before I hit return? Perhaps it could even be a primitive auto-correct if it could insert backspace chars.
Is this a basic string match or a regex match? A regex would allow passing matched groups to the input/notification/external command/etc as arguments.
Whats the performance like with infinite scrollback and/or lots of terminals?
I'd be wary of having this active for all terminals by default. Perhaps it could be tied in to Profiles somehow, so that strings are only checked/matched in terminals that are running a particular Profile.
I recommend you to push your branch to Launchpad. Then I and others can take a look and play around with it.
Hi Wesley. Definitely something I think would be an interesting addition. Obviously I don't know how you've implemented this, so I'd have to see the code to give more thoughts or opinions. Just a few quick thoughts that occur to me:
Does this only match output, or input too? i.e. Can I sound a big siren if I type "rm -rf" before I hit return? Perhaps it could even be a primitive auto-correct if it could insert backspace chars.
Is this a basic string match or a regex match? A regex would allow passing matched groups to the input/notificat ion/external command/etc as arguments.
Whats the performance like with infinite scrollback and/or lots of terminals?
I'd be wary of having this active for all terminals by default. Perhaps it could be tied in to Profiles somehow, so that strings are only checked/matched in terminals that are running a particular Profile.
I recommend you to push your branch to Launchpad. Then I and others can take a look and play around with it.