crash when gconf is inaccessible or configuation gets fail

Bug #1579446 reported by Nix
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terminator
Invalid
Undecided
Unassigned

Bug Description

When GConf is present but inaccessible (running as a different user, on a different machine sharing the same $HOME over NFS, etc), or indeed if other errors happen when acquiring gconf info, we get a crash at startup as terminator tries to acquire defaults:

Traceback (most recent call last):
  File "./terminator", line 120, in <module>
    TERMINATOR.create_layout(OPTIONS.layout)
  File "/usr/src/terminator/terminator/terminatorlib/terminator.py", line 283, in create_layout
    window, terminal = self.new_window()
  File "/usr/src/terminator/terminator/terminatorlib/terminator.py", line 208, in new_window
    terminal = maker.make('Terminal')
  File "/usr/src/terminator/terminator/terminatorlib/factory.py", line 94, in make
    output = func(**kwargs)
  File "/usr/src/terminator/terminator/terminatorlib/factory.py", line 106, in make_terminal
    return(terminal.Terminal())
  File "/usr/src/terminator/terminator/terminatorlib/terminal.py", line 173, in __init__
    self.reconfigure()
  File "/usr/src/terminator/terminator/terminatorlib/terminal.py", line 778, in reconfigure
    self.titlebar.update()
  File "/usr/src/terminator/terminator/terminatorlib/titlebar.py", line 116, in update
    title_font = Pango.FontDescription(self.config.get_system_prop_font())
  File "/usr/src/terminator/terminator/terminatorlib/config.py", line 373, in get_system_prop_font
    '/desktop/gnome/interface/font_name')
GLib.Error: gconf-error-quark: Failed to contact configuration server; some possible causes are that you need to enable TCP/IP networking for ORBit, or you have stale NFS locks due to a system crash. See http://projects.gnome.org/gconf/ for information. (Details — 1: Failed to get connection to session: Could not connect: Connection refused) (2)

It is clearly better to silently drop said defaults than to crash.

Patch to do that attached.

Related branches

Revision history for this message
Nix (nix-esperi) wrote :
Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Hi Nix, thanks for the patch, but it turns out I "fixed" this already when making a change to move away from old gtk2 GConfig to new gtk3 DConfig, fixing: https://bugs.launchpad.net/terminator/+bug/1655446

You can see the change: http://bazaar.launchpad.net/~gnome-terminator/terminator/gtk3/revision/1697

I'm going to mark this as invalid, as it no longer applies.

Changed in terminator:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.