(gtk3) G_REGEX_MULTILINE issue

[Egmont Koblinger]

When starting up terminator-gtk3 (bzr) with vte-0.44, the following is printed a couple of times:

(terminator:12345): Vte-WARNING **: (vtegtk.cc:1704):int vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)

The following changes are relevant:
https://git.gnome.org/browse/vte/commit/?id=d847452
https://git.gnome.org/browse/vte/commit/?id=7fdb3d1

[Stephen Boddy (stephen-j-boddy)]

Does this cause Terminator to fail to start, break searches, or is it just a warning?

I'm guessing here but I suppose I have to add the multiline flag in the call if the VTE version is 0.44+

[Egmont Koblinger (egmont-gmail)]

Just a warning.

> I'm guessing here but I suppose I have to add the multiline flag in the call if the VTE version is 0.44+

I guess so too. Haven't verified.

[Egmont Koblinger (egmont-gmail)]

I think you can add that flag unconditionally. Don't know for sure, though.

[Stephen Boddy (stephen-j-boddy)]

Egmont, can you check this is OK with vte 0.44 (or newer). It doesn't cause any issue with my 0.42.5. If it works for you I'll commit it, then if it causes issues with older versions it's a trivial test for the version to adjust the regex_flags variable.

[Egmont Koblinger (egmont-gmail)]

Looks okay (URLs are still underlined as expected, warnings are gone).

Just for the record: This is with vte-0.44, as reported originally. With vte-0.47.90 there are no warnings even without the patch. Apparently works equally good with and without this patch. Still, I guess this patch is the way to go.

[Stephen Boddy (stephen-j-boddy)]

For sure, or we just get bug reports from everyone on 0.44 all the time. I'll commit it.

[Stephen Boddy (stephen-j-boddy)]

Committed revision 1737.