Can't drag-n-drop link

[Egmont Koblinger]

Drag-n-drop a link from your browser (tested with ff & chrome) to terminator. It doesn't work.

(terminator:12345): Vte-WARNING **: Error (Invalid or incomplete multibyte or wide character) converting data for child, dropping.

(even if the URL is plain ASCII)

(See also bug 1498819)

[Egmont Koblinger (egmont-gmail)]

Drag-n-dropping from e.g. Gnome's file manager "Files" works as expected.

From firefox, the data we receive is encoded in UTF-16 wtf??

Looks like a ff bug that we have to workaround.

From gnome-terminal:

    case TARGET_MOZ_URL:
      {
        char *utf8_data, *newline, *text;
        char *uris[2];
        gsize len;

        /* MOZ_URL is in UCS-2 but in format 8. BROKEN!
         *
         * The data contains the URL, a \n, then the
         * title of the web page.
         */
        if (selection_data_format != 8 ||
            selection_data_length == 0 ||
            (selection_data_length % 2) != 0)
          return;

        utf8_data = g_utf16_to_utf8 ((const gunichar2*) selection_data_data,
                                     selection_data_length / 2,
                                     NULL, NULL, NULL);

        ...

[Egmont Koblinger (egmont-gmail)]

Note: the dnd text is two lines: one is the URL, the second is the visible text. Process only the first line, as expected.

g-t contains a few safety check (data_format needs to be 8, etc.) which I didn't care porting, but feel free to make it more robust.

[Stephen Boddy (stephen-j-boddy)]

Affected gtk2 too.