(gtk3) Separator size doesn't work

Bug #1518069 reported by Egmont Koblinger
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Terminator
Medium
Unassigned

Bug Description

Preferences -> Global -> Terminal separator size is a slider from -1 to 5.

No matter what I set it to, the separator is always 6 pixels for me.

I'm also wondering what's the purpose of a negative number, and also 0 should only be allowed if there's a way to resize the panes by keyboard, without dragging the separator.

Related branches

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Also in GTK 3.10

-1 uses the theme default width
0-5 set it to that many pixels. 0 draws no line, but can still be dragged with the mouse, although in my opinion it is a pain in the butt to use. And we do have keyboard shortcuts to resize too.

Changed in terminator:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Okay, then let me squeeze in another additional feature request here: -1 is totally user-unfriendly, maybe that should be a separate checkbox, similarly to e.g. the font chooser.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Totally agree. I've tried to improve usability, but that is a very valid criticism.

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

terminatorlib/terminator.py reconfigure() sets it, but it's so totally gtk2...

What we'd need to apply is probably this (as the first step; once it works then figure out how to restrict it to terminator-paned-style):

* {
        -GtkPaned-handle-size: %s
}

How to apply this has also changed, we'd need to figure that out too. Vte has an example of programatically applying the "padding: 1px" property: https://git.gnome.org/browse/vte/tree/src/vtegtk.cc?id=20aba53#n1410

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

On a related note, the code to remove this style when the slider is set to -1 is missing. So you can't runtime reset to the theme default, setting to -1 only takes effect after restarting Terminator. (Tested with the gtk2 version.)

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :
Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

In rev 1689 for trunk if applicable.
In rev 1627 for gtk3 if applicable.

Changed in terminator:
status: Confirmed → Fix Committed
Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers