Ability to add padding to the terminal

Bug #1472689 reported by Markus Hallfors
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Terminator
Wishlist
Unassigned

Bug Description

Something like "padding: 10px" to the config file would be nice addition.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

I'm not clear (in graphical terms) what you are asking for. Perhaps a mockup?

Changed in terminator:
importance: Undecided → Wishlist
summary: - Wishlist: Ability to add padding to the terminal
+ Ability to add padding to the terminal
Changed in terminator:
status: New → Incomplete
Revision history for this message
Markus Hallfors (destroyerko) wrote :

Maybe this mockup helps.

For example in GNOME terminal you can just add this to gtk.css to get the same result:
VteTerminal,
TerminalScreen {
    padding: 10px 10px 10px 10px;
    -VteTerminal-inner-border: 10px 10px 10px 10px;
}

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

OK. As a utilitarian it seems a waste of valuable pixels to me ;-)

Perhaps someone agrees with your sense of aesthetics and will figure out how to do this. As a hint to that person, the 0.28 VTE has a style property for inner-border. It's not clear code-wise how to do this in 0.38+ vte.

Changed in terminator:
status: Incomplete → Triaged
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

I think if Terminator ported to 0.38+ then the gtk.css fragment above would automatically work for Terminator too. I'm not sure what'd be the benefit of a Terminator-specific config option in its own config file.

Note that -VteTerminal-inner-border is for <=0.36, padding is for >=0.38.

tags: removed: wishlist
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

So, for the gtk3 branch (vte >= 0.38):

As said above, the CSS that needs to be applied goes something like:

VteTerminal {
    padding: 10px;
}

or four parameters in the usual CSS top-right-bottom-left order if different paddings are desireable for each side (nb. with overlay scrollbar [bug 1512106] it might make sense to have a larger padding on the scrollbar's side so that it's not that much overlaid after all).

As for how to apply such a CSS from the code, see the patch from bug 1518069.

Revision history for this message
Markus Hallfors (destroyerko) wrote :

Just changed to the GTK3 branch and now that it reads the gtk.css file, I got what I wanted :).

This can be closed, as the feature is coming in the gtk3 branch.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Awesome!

Changed in terminator:
status: Triaged → Fix Committed
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Beginning with gnome 3.20 / vte 0.44, the CSS selector needs to be "vte-treminal" rather than "VteTerminal". Go for

VteTerminal, vte-terminal {
  padding: ...;
}

to be compatible with both.

Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers