Terminator doesn't fully maximize in KDE

[aditsu]

I'm using Terminator 0.97 in Gentoo Linux, with KDE 4.14.3. When I maximize the Terminator window, it doesn't cover the whole screen, but leaves some space around all the edges. Through that space I can still see the windows behind, and what's even worse is that I can actually click around the supposedly maximized Terminator and switch to those windows.
I noticed the same problem on another computer running Ubuntu and an older KDE version.

[Stephen Boddy (stephen-j-boddy)]

Hi Bug subscribers, this is the maintainer (Steve Boddy) of Terminator, who took over from Chris.

In case you were not aware there has been a new release 0.98 of Terminator in the last few days which has many changes, fixes and updates. We also have an ongoing GTK3 port which uses a much more up-to-date libvte.

Even with the ~50 issues closed by that release, and discounting the ~90 outstanding wishlist items, we still have an unwieldy 95 bugs. With the oldest approaching it's 6th birthday and some that haven't seen any updates in nearly 5, it is time for a purge.

My intention is to try and get this list down to a minimum, and for that I need your help.

First I'm going to work through, oldest to newest, setting bugs to Incomplete, pending confirmation that they are still an issue. If after a month there is no feedback, the issue will get closed as Invalid. Here's where you come in. I can't always reproduce, or setting up (i.e. other distros) to even test takes a long time, so I'm going to try crowdsourcing this.

1. Get the latest release. Is it still an issue? If yes, set the confirmed-0.98 tag. For bonus points follow the guide http://gnometerminator.blogspot.com/2015/09/so-you-want-to-try-terminator-gtk3.html and see if the GTK3 branch has same issue, and set the confirmed-gtk3 or notaffected-gtk3 tag.

2. Can you reproduce with an empty/default config file? You can pass "-g temp_config" to do this without affecting your existing config. If you already have Terminator running, you'll need to pass -u as well to disable the DBus.

3. If able to, can you reproduce with another user/guest account?

4. If the issue does not already have clear, precise instructions to reproduce with minimal setup/steps, add them.

5. Put as much info about what you are running.
   * Software/library versions (libvte, gtk, pango, cairo, distro, desktop environment, language)
   * Screens (single or multi)
   * Any unusual / custom packages or configs that might be interacting.

6. If possible attach the config file, unless the issue also happens with an empty one, but mention that.

7. Attach the "-d" debug output from 0.98.

Some common things that cause incidents.

* Strange sizing issues or rapidly shrinking windows - Try turning off Window geometry hints.
* Input (esp. broadcasting duplicate chars etc) problems - Try killing IBus.
* Hand editing of the config file can cause various issues - Due to misunderstanding, incorrect structure or typos.
* Some issues are actually in libvte - This is why testing GTK3 is so important.
* segfaults - Unfortunately these are dying inside the C libraries, and it is usually beyond me to fix those.

Many thanks for your assistance, and hopefully this will get us closer to a bug-free Terminator.

[aditsu (aditsu)]

I tried version 0.98 and it has the same problem

[Stephen Boddy (stephen-j-boddy)]

As stated in the bulk message, we get frequesnt quirks of window sizing due to window geometry hints, but you do not mention checking that.

Do you have window geometry hinting turned on? I suspect that might be causing setting the window to a slightly smaller size based on how many chars are displayable. Try turning it off, and retrying maximise.

If this prevents the border, then it seems this is specific to KDE.

[Stephen Boddy (stephen-j-boddy)]

Also, please don't set the status back to New. For this big purge or verify crusade that I'm on, I'm looking to have all pre 0.98 bugs Incomplete, Confirmed, Invalid, or Triaged. You *Confirmed* in your comment, but set the ticket back to New.

So non team-members can set them to Confirmed, and if a team-member can reproduce reliably, then it goes to Triaged, with severity and reproduction steps etc.

(Not having a go at you, I'm just trying to maintain order while a drive stakes through the hearts of these undead issues :-)

[aditsu (aditsu)]

Hi, I know you mentioned that, but I don't know what are "window geometry hints" and where to check them. Can you please elaborate?
About the status, sometimes I got blamed by developers in other bug trackers when I marked a bug as "confirmed" (or something similar) because they hadn't reproduced it or did not agree it was a bug. Sometimes it's hard to tell what the different statuses really mean, what's the workflow and what authority I have.

[Stephen Boddy (stephen-j-boddy)]

Right-click -> Preferences, Global tab, Behaviour section, "Window geometry hints"

Tip: There is a *very* thorough manual now (press F1, or use the button available under the About tab in Prefs. It has a search feature too!

Regarding the workflow, and having other developers being dicks to you. I don't really consider myself a "developer", more of an overly-ambitious user, so hopefully I'm a bit friendlier. After I bite, I hand you the antiseptic and a bandage ;-) Of course if after been given advice/help etc, someone keeps repeatedly doing dumb stuff, I reserve the right to rip off one of their arms and beat them with it.

[aditsu (aditsu)]

Ah, that was a Terminator setting! After disabling it and completely restarting terminator, I was able to maximize it properly, thanks.
I tried pressing F1 but the only thing that happened was that a light bulb appeared in the top right corner, then disappeared.
The workflow thing is (by far) not the worst thing I've experienced while reporting/discussing bugs, I wouldn't really call them dicks just for that :p I'm a developer myself btw.
Thanks for maintaining Terminator :)

[Stephen Boddy (stephen-j-boddy)]

Did you actually update to 0.98? Do you have an About tab in the Prefs? These things only appear in 0.98. If you have the tab there should be a button "The Manual" which would launch the manual. If you have these things and they don't work, then there is an issue that you should raise. Most likely because you're running under KDE, which is a bit unusual :-)

But once again confirmation that Window geometry hints are the illegitimate offsping of the Devil and Pandora. I'm beginning to strongly suspect that the best answer is to simply rip them out.

I don't have a KDE to replicate myself, so I'm leaving as Confirmed for now.

[aditsu (aditsu)]

Yes, I'm 100% absolutely sure I updated it. I went to Preferences - About and clicked "The Manual", but nothing happened. I got it to work by reinstalling terminator with the "doc" USE flag enabled (a Gentoo thing) - "The Manual" now opens a documentation page in my browser. F1 still doesn't work though. And clicking the links under "The Manual" opens them with the wrong browser.
Btw, the About tab would be a good place to show the version number.

[Stephen Boddy (stephen-j-boddy)]

OK, I'm closing this bug as the original issue is resolved by disabling the window geometry hints. I'm very strongly leaning towards removing these. They cause numerous bugs and issues, for for seems like very little gain.

@aditsu: Please raise a new issue for that weirdness going on with the F1 event key under KDE.

Marking as Invalid as no code required.

[aditsu (aditsu)]

About the F1 problem, I think bug 1494606 covers it.
As for this bug, I don't really agree with the decision. The "window geometry hints" setting should be either fixed or removed, or at least disabled by default. There is "code required" for each of these 3 alternatives. If this bug remains invalid, I will open a new one specifically about that setting.