get_pid_cwd support for Mac OSX

Bug #1261293 reported by Heon Jeong
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Undecided
Unassigned

Bug Description

in cwd.py there is no support for 'Darwin' kernel so It falls back to

    func = lambda pid: None

I tried to find a way using traditional procfs, but it seems osx doesn't support procfs...

but if we allow to use 'psutil'(which can be installed via pip), there is a way to get cwd using that.

I wrote a patch(against 0.97 - which can be conflict with development version, but patch is quite simple)

and hope it gets merged.

PS> bzr in my workplace doesn't work to fetch repository... so sad :(

Related branches

Revision history for this message
Heon Jeong (blmarket) wrote :
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Note that porting Terminator to newer VTE (bug 1030562) would make this bug obsolete, as it no longer relies on an OS-specific way to get the working directory.

Changed in terminator:
milestone: none → 1.0
Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

A little adjustment by yours truly, but it is in there.

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

As rev. 1617

Changed in terminator:
status: New → Fix Committed
Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.