NoneType error in get_system_focus

[Avinash Meetoo]

When launched in Fedora, terminator provokes a NoneType error in get_system_focus.

The reason is that self.gconf.get('/apps/metacity/general/focus_mode') evaluates to None and, consequently, doing get_string() on it fails (line 344 in /usr/lib/python2.7/site-packages/terminatorlib/config.py)

My solution, which I've tested, and, so far, works is to change line 344 to:

            if value is not None:
                self.system_focus = value.get_string()

[Chris Jones (cmsj)]

Which version of Terminator are you using? I think this is already fixed, that code in trunk is guarded by "if value:" which is equivalent to your suggestion.

[Avinash Meetoo (avinash)]

Ok.

I'm using terminator 0.96 in Fedora 18 and, as far as I can see, this is the latest version of terminator and, in Fedora at least, the bug still exists.

Avinash

[Chris Jones (cmsj)]

Hi

Are you able to test with trunk? (this will be released as 1.0 shortly)

bzr branch lp:terminator
cd terminator
./terminator --no-dbus

Cheers,

Chris

On 27 February 2013 18:54, Avinash Meetoo <email address hidden> wrote:

> Ok.
>
> I'm using terminator 0.96 in Fedora 18 and, as far as I can see, this is
> the latest version of terminator and, in Fedora at least, the bug still
> exists.
>
> Avinash
>
> --
> You received this bug notification because you are subscribed to
> Terminator.
> https://bugs.launchpad.net/bugs/1126116
>
> Title:
> NoneType error in get_system_focus
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/terminator/+bug/1126116/+subscriptions
>

[Avinash Meetoo (avinash)]

Hi,

I've checked. The latest trunk has the required correction.

Thanks for the trouble.
Avinash

[Chris Jones (cmsj)]

Hi

Great! Thanks for testing.

Cheers,

Chris

[V. Bakayev (vbakayev)]

reference to Fedora bugzilla downstream ticket:
https://bugzilla.redhat.com/show_bug.cgi?id=820690