Unequal and sub-optimal splits

[Ben Slusky]

A concrete example: On my PC at work, Terminator in full-screen mode gives me a terminal window with a width of 131 characters. When I split that horizontally, the child windows are 64 and 63 characters in width. However, I can nudge the separator a bit and make both windows 64 characters in width. Why couldn't Terminator just do that on its own?

This happens on other displays as well as my work PC, with vertical splits as well as horizontal, with every release from 0.11 (possibly earlier) up to 0.96. It should be trivially reproducible.

[Stephen Boddy (stephen-j-boddy)]

Yeah some ratio code was added in a while ago, and I can see where they missed out accounting for the size of the handle/seperator.

I have a trivial fix for the trivially reproducable problem.

[Stephen Boddy (stephen-j-boddy)]

Not quite sure why this got set to fix released. It is now committed as revision 1579

[Stephen Boddy (stephen-j-boddy)]

I should also mention: If you have saved layouts the splitters will have shifted a few pixels. When you originally saved them they used the ratio of the edge of the splitter. With this fix they saved the middle point. i.e. before your ratio might have been 0.49957663637 for a perfect 50:50 split. That would need to be changed to 0.5 now. Or you could re-equalize the splits, and use the new "Save" button to update the current layout.