Can't use <Shift>asciitilde keybinding for hide_window

[brisssou]

Hello,

this combinaison doesn't work, nor any one using the twosuperior key...

It does not even get saved: if I set the binding to the said shortcut, I can't toggle terminator visibility.

As a testing scenario, I :
==PHASE1==
* set the shortcut to F12
* launch terminator with "dbH" switches
* display terminator using F12
* open the preferences screen
* hide terminator using F12
* change the binding to <Shift>asciitilde using the preferences screen (the change is reported to the config file)
* display terminator using F12
* kill terminator using logout
==PHASE2==
* launch terminator with "dbH" switches
==> can't see it
* kill terminator using ctrl+C from the terminal that launched it.

You'll find the two debug outputs attached as archive.

Thanks for your help!
Brice.

[brisssou (brice-laurencin)]

to be more precise, the <Shift>asciitilde gets into the conf file, but if I display again the preferences, the binding is shown as unbinded.

[Tom Smith (takeontom)]

Can not replicate this issue on the below environment.

Followed the steps to reproduce and the preferences do show the key binding.

$ lsb_release -rd; apt-cache policy terminator
Description: Ubuntu quantal (development branch)
Release: 12.10
terminator:
  Installed: 0.96-0ubuntu1
  Candidate: 0.96-0ubuntu1
  Version table:
 *** 0.96-0ubuntu1 0
        500 http://gb.archive.ubuntu.com/ubuntu/ quantal/universe amd64 Packages
        100 /var/lib/dpkg/status

[Stephen Boddy (stephen-j-boddy)]

Hi Bug subscribers, this is the maintainer (Steve Boddy) of Terminator, who took over from Chris.

In case you were not aware there has been a new release 0.98 of Terminator in the last few days which has many changes, fixes and updates. We also have an ongoing GTK3 port which uses a much more up-to-date libvte.

Even with the ~50 issues closed by that release, and discounting the ~90 outstanding wishlist items, we still have an unwieldy 95 bugs. With the oldest approaching it's 6th birthday and some that haven't seen any updates in nearly 5, it is time for a purge.

My intention is to try and get this list down to a minimum, and for that I need your help.

First I'm going to work through, oldest to newest, setting bugs to Incomplete, pending confirmation that they are still an issue. If after a month there is no feedback, the issue will get closed as Invalid. Here's where you come in. I can't always reproduce, or setting up (i.e. other distros) to even test takes a long time, so I'm going to try crowdsourcing this.

1. Get the latest release. Is it still an issue? If yes, set the confirmed-0.98 tag. For bonus points follow the guide http://gnometerminator.blogspot.com/2015/09/so-you-want-to-try-terminator-gtk3.html and see if the GTK3 branch has same issue, and set the confirmed-gtk3 or notaffected-gtk3 tag.

2. Can you reproduce with an empty/default config file? You can pass "-g temp_config" to do this without affecting your existing config. If you already have Terminator running, you'll need to pass -u as well to disable the DBus.

3. If able to, can you reproduce with another user/guest account?

4. If the issue does not already have clear, precise instructions to reproduce with minimal setup/steps, add them.

5. Put as much info about what you are running.
   * Software/library versions (libvte, gtk, pango, cairo, distro, desktop environment, language)
   * Screens (single or multi)
   * Any unusual / custom packages or configs that might be interacting.

6. If possible attach the config file, unless the issue also happens with an empty one, but mention that.

7. Attach the "-d" debug output from 0.98.

Some common things that cause incidents.

* Strange sizing issues or rapidly shrinking windows - Try turning off Window geometry hints.
* Input (esp. broadcasting duplicate chars etc) problems - Try killing IBus.
* Hand editing of the config file can cause various issues - Due to misunderstanding, incorrect structure or typos.
* Some issues are actually in libvte - This is why testing GTK3 is so important.
* segfaults - Unfortunately these are dying inside the C libraries, and it is usually beyond me to fix those.

Many thanks for your assistance, and hopefully this will get us closer to a bug-free Terminator.

[Stephen Boddy (stephen-j-boddy)]

Hi, maintainer here. Terminator has moved on from gtk2 and we now have a brand-spanking new gtk3 version. Sadly we also have many ancient bugs, and it's not really practical to struggle to replicate them considering how widely the code bases have diverged.

I'm setting these older bugs to Invalid. If you wish to reactivate the bug please reproduce with at least gtk3 and release 1.90 (even better if you use head of the gtk3 branch), then set the status to New. This way we only have to focus on things that still impact users.

[brisssou (brice-laurencin)]

Hello Stephen,

Thanks for your dedication to this marvel of a terminal.

I just tested this again, from a fresh bzr checkout.

$ terminator --version
terminator 1.90

With my current keyboard setup, asciitilde became twosuperior and when trying to bind it with <shift>, the conf states <shift>threesuperior.

And it still does not work.
The terminator window's head (red header with the name, size of the terminal) merely blinks.

Would this need more details, I'll more than happy to help.

Brice.

[Stephen Boddy (stephen-j-boddy)]

See https://bugs.launchpad.net/terminator/+bug/999897/comments/6

It's essentially the same issue. We're adding an unnecessary <Shift> modifier in the setting.

I'm going to make this a dupe of 999897.

[Stephen Boddy (stephen-j-boddy)]

Committed revision 1708.

Turns out it isn't a dupe. The hide key is the only one that is sent to Keybinder, and is handled by a different bit of code. In this case if the binding uses a shift key, it doesn't work. This one line fix makes shifted keys work properly.

[brisssou (brice-laurencin)]

I confirm the fix works! thanks!