test_list_images fails

[David Kranz]

This test seems to think that there should be a 'instance_ref' metadata key but there is not. I don't know if this test is buggy or some unknown (to me) spec about the metadata is being violated by nova.

======================================================================
ERROR: The list of servers should be filtered by server ref
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/cygdrive/c/source/tempest/tempest/tests/test_list_images.py", line 129, in test_list_images_filter_by_server_ref
    params = {'server': self.image3['metadata']['instance_ref']}
KeyError: 'instance_ref'

======================================================================
ERROR: Detailed list of servers should be filtered by server ref
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/cygdrive/c/source/tempest/tempest/tests/test_list_images.py", line 213, in test_list_images_with_detail_filter_by_server_ref
    params = {'server': self.image3['metadata']['instance_ref']}
KeyError: 'instance_ref'

[Daryl Walleck (dwalleck)]

It was my understanding that this is a core feature of glance, which may be incorrect. Let me check with my devs and I'll adjust the test if needed.

[Jay Pipes (jaypipes)]

This is actually not a Glance thing (Glance has no concept of an image_ref) AFAIK, this is solely the realm of the Compute API, which has an imageRef (not image_ref) key in the *Request* dictionary sent to the Create Servers call:

http://docs.openstack.org/api/openstack-compute/2/content/CreateServers.html

I don't believe that image_ref is used anywhere else.

So, looks to me like the test is simply wrong.

[David Kranz (david-kranz)]

Jay, I think you mean these two cases should just be removed, right?

[Daryl Walleck (dwalleck)]

The purpose of these tests is to test the server filter parameter for list images, which is documented functionality. My environment is obviously different, so I can just rewrite where the server ref is coming from.

[Daryl Walleck (dwalleck)]

Turns out the server_ref field was moved from metatdata of an image to an actual property of the image.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4523

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4523
Committed: http://github.com/openstack/tempest/commit/97d751748d0d59d2f767ccd5eadc51c961127d82
Submitter: Jenkins
Branch: master

commit 97d751748d0d59d2f767ccd5eadc51c961127d82
Author: Daryl Walleck <email address hidden>
Date: Fri Feb 24 18:54:10 2012 -0600

    Fixes lp#940532

    * Changes image filter by server_ref tests since
      the location of the property was modified

    Change-Id: I3dc55323402b766d6b12df8660e35b8bf2b16112