tempest init fails with 'OptGroup' object is not iterable

[Martin Kopec]

tempest-tox-plugin-sanity-check job started failing 2 days ago (Feb 10th) on 'tempest init' with plugins with:
'OptGroup' object is not iterable

https://zuul.opendev.org/t/openstack/builds?job_name=tempest-tox-plugin-sanity-check&project=openstack/tempest

Passed Plugins: , airship/tempest-plugin'
Failed Plugins: openstack/barbican-tempest-plugin, openstack/blazar-tempest-plugin, openstack/cinder-tempest-plugin, openstack/cloudkitty-tempest-plugin, openstack/cyborg-tempest-plugin, openstack/designate-tempest-plugin, openstack/ec2api-tempest-plugin, openstack/freezer-tempest-plugin, openstack/glance-tempest-plugin, openstack/heat-tempest-plugin, openstack/ironic-tempest-plugin, openstack/keystone-tempest-plugin, openstack/kuryr-tempest-plugin, openstack/magnum-tempest-plugin, openstack/manila-tempest-plugin, openstack/mistral-tempest-plugin, openstack/monasca-tempest-plugin, openstack/murano-tempest-plugin, openstack/neutron-tempest-plugin, openstack/octavia-tempest-plugin, openstack/sahara-tests, openstack/senlin-tempest-plugin, openstack/solum-tempest-plugin, openstack/telemetry-tempest-plugin, openstack/trove-tempest-plugin, openstack/venus-tempest-plugin, openstack/vitrage-tempest-plugin, openstack/watcher-tempest-plugin, openstack/whitebox-tempest-plugin, openstack/zaqar-tempest-plugin, openstack/zun-tempest-plugin, x/almanach, x/gabbi-tempest, x/networking-cisco, x/tap-as-a-service-tempest-plugin, x/whitebox-neutron-tempest-plugin, '

[Martin Kopec (mkopec)]

Steps to reproduce:
1. install tempest
2. install a plugin
3. run 'tempest init'

[Martin Kopec (mkopec)]

It fails on this line:
            group_opts = list(group_opts)
in here:
https://opendev.org/openstack/oslo.config/src/commit/882adf8e4d0685ea3404067fa38066abec9bd5f6/oslo_config/generator.py#L535

with at least barbican-tempest-plugin. All other group_opts there are a list, only the one from the barbican-tempest-plugin is a dict. Although I don't understand why it fails, as the list() should convert the group_opts to a list.

[Martin Kopec (mkopec)]

Coincidentally, the same day when the job started failing, oslo.config released a new version:
https://pypi.org/project/oslo.config/#history
but downgrade to the previous one didn't help.

[Martin Kopec (mkopec)]

making the job non-voting for now:
https://review.opendev.org/c/openstack/tempest/+/909022

[Martin Kopec (mkopec)]

The job seems to be passing now, it has been for a while:
https://zuul.opendev.org/t/openstack/builds?job_name=tempest-tox-plugin-sanity-check&project=openstack/tempest

Couple of latest failures were caused by missing pytz but that was fixed by: https://review.opendev.org/c/openstack/monasca-tempest-plugin/+/911574

The job hasn't fail with the reason in this LP for a while now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tempest/+/912372

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tempest/+/912372
Committed: https://opendev.org/openstack/tempest/commit/26dce72617a04c4b3a54fe49c5e5b3dd80a41758
Submitter: "Zuul (22348)"
Branch: master

commit 26dce72617a04c4b3a54fe49c5e5b3dd80a41758
Author: Martin Kopec <email address hidden>
Date: Mon Mar 11 11:06:25 2024 +0100

    Make plugin sanity check job voting again

    The job hasn't fail with the reason it was marked non-voting for,
    for a while now.

    Closes-Bug: #2053026
    Change-Id: I035925416c9420624ea5d55b6bc5c1b08fcacf25

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 38.0.0 release.