Catch json exception in TaggedBootDevicesTest.verify_device_metadata

Bug #1867904 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
High
Rodolfo Alonso

Bug Description

In case "TaggedBootDevicesTest.verify_device_metadata" "json.loads" method returns an exception, catch it and return "False". Because this function is called in an active wait loop, it will be retried.

Log example: https://ac679f33d0e7a0356daa-25f3a3879427e395d97921f59eb3db3c.ssl.cf1.rackcdn.com/713281/1/check/neutron-tempest-linuxbridge/3a5bf84/testr_results.html

Log snippet: http://paste.openstack.org/show/790844/

Changed in tempest:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.opendev.org/713612

Changed in tempest:
status: New → In Progress
Martin Kopec (mkopec)
Changed in tempest:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.opendev.org/713612
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=f77b3e30eeeb67c54244def7e50fbb68113379d3
Submitter: Zuul
Branch: master

commit f77b3e30eeeb67c54244def7e50fbb68113379d3
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Mar 18 10:19:53 2020 +0000

    Catch json.loads exceptions in verify_device_metadata

    In case "TaggedBootDevicesTest.verify_device_metadata" "json.loads"
    method returns an exception, catch it and return "False". This could
    happen if, for example, the string to load is empty.

    Because this function is called in an active wait loop, the content
    string will be retrieved again and the check retried.

    Change-Id: Id3a5b32f8ab197bcb1c59b5f6364dde4d8648eab
    Closes-Bug: #1867904

Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.