TestNetworkBasicOps.test_network_basic_ops is racy

[Soren Hansen]

tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_network_basic_ops was failing for me pretty consistently. Adding a few strategically placed time.sleep(10) fixed it.

Digging through tempest's logs, I can see that it gets the list of ports for the VM and since the port is not active, it immediately gives up. The port is in state "BUILD". Waiting a number of seconds sorts it out.

[Martin Kopec (mkopec)]

What's the status here? Is it in progress? Also could you please share more info, some tracebacks and logs etc ..

[Martin Kopec (mkopec)]

Seems that the test should check if the port is in ACTIVE state and if it's not , it should wait for it. A port is created here [1] by this method [2] in which we could use call_until_true method like in this case of floating ip for example [3].

Moving to Confirmed state and dissociating assignee as no one seems to work on this atm.

[1] https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_network_basic_ops.py#L116-L119
[2] https://opendev.org/openstack/tempest/src/commit/5c191faae78f52f876edba72484ea644d3df04fd/tempest/scenario/manager.py#L140-L155
[3] https://opendev.org/openstack/tempest/src/commit/5c191faae78f52f876edba72484ea644d3df04fd/tempest/scenario/manager.py#L1040-L1047

[Martin Kopec (mkopec)]

https://review.opendev.org/c/openstack/tempest/+/857756

[Martin Kopec (mkopec)]

while review traiging I stumbled upon a review which tried to address this LP before the latest patch (857756). I'm just gonna make a note of that patch here if needed for any future reference ...
https://review.opendev.org/c/openstack/tempest/+/685039

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Martin Kopec <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tempest/+/685039
Reason: abandoning due to a long inactivity and the fact that there is a new patch trying to address the same bug, feel free to restore this if needed

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tempest/+/857756
Committed: https://opendev.org/openstack/tempest/commit/bec2d4daa00f66681043d582fc32d2a7a819c337
Submitter: "Zuul (22348)"
Branch: master

commit bec2d4daa00f66681043d582fc32d2a7a819c337
Author: Eliad Cohen <email address hidden>
Date: Wed Sep 14 17:52:59 2022 +0000

    Added functionality to wait for port creation

    Added a waiter that compares the current status
    of the port to a target value and returns the port
    when that is achieved.

    Closes-Bug: 1845486
    Change-Id: Ibc5434244f3758c60ddefa96d78476948a47ed13

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 34.0.0 release.