Fix bug of test_change_server_password

[zhangyangyang]

Envirnment: R openstack

Test tool: rally & tempest

Desc: When I run the case of test_change_server_password, it reports some error,like this:

      2019-04-22 11:18:16.188 22577 INFO tempest.lib.common.rest_client [req-76f2e4c1-ae2b-49d7-b5d7-8c52b9b54229 ] Request (ServerActionsTestJSON:_run_cleanups): 409 DELETE http://172.21.88.10:9696/v2.0/security-groups/8a50af2c-3805-4f84-818d-d811623ddcda 0.112s
2019-04-22 11:18:16.189 22577 DEBUG tempest.lib.common.rest_client [req-76f2e4c1-ae2b-49d7-b5d7-8c52b9b54229 ] Request - Headers: {'Content-Type': 'application/json', 'Accept': 'application/json', 'X-Auth-Token': '<omitted>'}
        Body: None
    Response - Headers: {'status': '409', u'content-length': '136', 'content-location': 'http://172.21.88.10:9696/v2.0/security-groups/8a50af2c-3805-4f84-818d-d811623ddcda', u'date': 'Mon, 22 Apr 2019 03:18:16 GMT', u'content-type': 'application/json', u'connection': 'close', u'x-openstack-request-id': 'req-76f2e4c1-ae2b-49d7-b5d7-8c52b9b54229'}
        Body: {"NeutronError": {"message": "Security Group 8a50af2c-3805-4f84-818d-d811623ddcda in use.", "type": "SecurityGroupInUse", "detail": ""}} _log_request_full /var/lib/rally/.rally/verification/verifier-6a8d5aed-68f0-475b-96f9-29be6fbc2ce3/repo/tempest/lib/common/rest_client.py:437
2019-04-22 11:18:16.189 22577 ERROR tempest.lib.common.validation_resources [-] Conflict while deleting security group 8a50af2c-3805-4f84-818d-d811623ddcda VM might not be deleted: Conflict: Conflict with state of target resource
Details: {u'message': u'Security Group 8a50af2c-3805-4f84-818d-d811623ddcda in use.', u'type': u'SecurityGroupInUse', u'detail': u''}
2019-04-22 11:18:16.189 22577 ERROR tempest.lib.common.validation_resources Traceback (most recent call last):
2019-04-22 11:18:16.189 22577 ERROR tempest.lib.common.validation_resources File "/var/lib/rally/.rally/verification/verifier-6a8d5aed-68f0-475b-96f9-29be6fbc2ce3/repo/tempest/lib/common/validation_resources.py", line 315, in clear_validation_resources
2019-04-22 11:18:16.189 22577 ERROR tempest.lib.common.validation_resources security_group_client.delete_security_group(sec_id)
2019-04-22 11:18:16.189 22577 ERROR tempest.lib.common.validation_resources File "/var/lib/rally/.rally/verification/verifier-6a8d5aed-68f0-475b-96f9-29be6fbc2ce3/repo/tempest/lib/services/network/security_groups_client.py", line 59, in delete_security_group

After testing the case ,vm should be deleted. But security group is still alive.So the vm can not be deleted.At last,the test failed.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/655593
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=c248f5962ec4abfd716822c3b3ba496fe0e9cfbb
Submitter: Zuul
Branch: master

commit c248f5962ec4abfd716822c3b3ba496fe0e9cfbb
Author: zhangyangyang <email address hidden>
Date: Wed Apr 24 18:54:52 2019 +0800

    Fix the bug of deleting security group after testing changing password.

    When deleting security group before vm is deleted, we will get 'the
    security group is in use' error, so this is to add addCleanup to ensure
    the vm is deleted before deleting security group.

    Closes-Bug:#1826301
    Change-Id: I3d4a3816196f42af3ea3f891473d09208651ae68

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 21.0.0 release.