tempest.api.volume.test_volumes_list.VolumesListTestJSON should ignore volume_size

[Andrew McLeod]

We are setting volume_size to 5GB to accomodate larger test images, but do not have 3x5GB in our test environment.

https://github.com/openstack/tempest/blob/master/tempest/api/volume/test_volumes_list.py#L28 states that the volume sizes will be 1GB, so either this comment should be updated, or - preferably - the test should be updated to ignore volume_size.

[Sahid Orentino (sahid-ferdjaoui)]

Andrew I may have not well understand. From my point of view the comment is saying by default this will create 3 volumes of 1G so it warns us to have at least an env ready to handle it. Probably because by default volume_size = 1 [0]

If you tweak volume_size with something else, the volumes created will take that into account [1]. I verified that in my env.

[0] https://docs.openstack.org/tempest/latest/sampleconf.html
[1] https://github.com/openstack/tempest/blob/master/tempest/api/volume/base.py#L110

[Martin Kopec (mkopec)]

Based on the long inactivity I'm assuming that the reporter's problem got resolved.

Moreover the Sahid's comment is correct, by default the size of volumes is 1GB [1] and that's the behavior the comment is mentioning. If a user tests with bigger volumes, more resources need to be available. Based on the test, the available resources required for it must be at least equal to 3 * CONF.volume.volume_size (which is by default 1GB [1]).
On the other hand I agree, that the comment could have mentioned that 3*1 is ONLY default behavior, but I don't think it's necessary to modify the comment - the code itself is kinda self explanatory.

[1] https://opendev.org/openstack/tempest/src/commit/5785a7d18040ed8e48f7f58ed8bff972f5f25e01/tempest/config.py#L875-L877