No handling to register workspace when using invalid/blank name of workspace

Bug #1791007 reported by Manik Bindlish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Undecided
Manik Bindlish

Bug Description

Ubuntu 16.04
Branch: master(Stein)

Wrongly able to create workspace with blank name

stack@control:~/tempest$ tempest workspace register --workspace-path /opt/stack/.tempest/workspace.yaml --name "" --path /opt/stack/tempest/
stack@control:~/tempest$ tempest workspace list
+------+--------------------+
| Name | Path |
+------+--------------------+
| | /opt/stack/tempest |
+------+--------------------+

Wrongly able to rename workspace name to blank name

 stack@control:~/tempest$ tempest workspace register --workspace-path /opt/stack/.tempest/workspace.yaml --name abc --path /opt/stack/tempest/
stack@control:~/tempest$ tempest workspace list
+------+--------------------+
 Name | Path |
+------+--------------------+
 abc | /opt/stack/tempest |
+------+--------------------+

stack@control:~/tempest$ tempest workspace rename --workspace-path /opt/stack/.tempest/workspace.yaml --old-name "abc" --new-name ""
stack@control:~/tempest$ tempest workspace list
+------+--------------------+
| Name | Path |
+------+--------------------+
| | /opt/stack/tempest |
+------+--------------------+

Changed in tempest:
assignee: nobody → Manik Bindlish (manikbindlish19)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/600343

Changed in tempest:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/600343
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=864f37eb66316707c9311d70fd66a94406b40f00
Submitter: Zuul
Branch: master

commit 864f37eb66316707c9311d70fd66a94406b40f00
Author: Manik Bindlish <email address hidden>
Date: Thu Sep 6 06:30:51 2018 +0000

    Handling invalid name of workspace register and rename.

    This PS will fix the invalid value handling.
    Error will be raised if no/blank value will be specified for
    workspace register name and workspace rename.

    Change-Id: Id8a3f496a8902bd7f0d66254ee8fa148675974e9
    Closes-Bug: #1791007

Changed in tempest:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tempest 20.0.0

This issue was fixed in the openstack/tempest 20.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.