Remove hard code cidr in test_create_server_multi_nic.

Bug #1743742 reported by Yikun Jiang
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Undecided
Pragadeeswaran Sathyanarayanan

Bug Description

Now, We have some hard code in empest\api\compute\servers\test_create_server_multi_nic.py,but in some public cloud env, VPC are limited to some specific address ranges by default.

such as:
1. for amazon cloud:
https://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_Subnets.html
10.0.0.0 - 10.255.255.255 (10/8 prefix)
172.16.0.0 - 172.31.255.255 (172.16/12 prefix)
192.168.0.0 - 192.168.255.255 (192.168/16 prefix)

2. also in alibaba cloud:
https://www.alibabacloud.com/help/doc-detail/53604.htm?spm=a3c0i.q54484zh.a3.4.2f074e0bD965pt
Use the standard private CIDR blocks (10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/1) or their subsets as the IP address ranges.

3. in huawei cloud:
http://support.huaweicloud.com/en-us/usermanual-vpc/en-us_topic_0030971614.html
The following CIDR blocks are supported:
10.0.0.0/8–24
172.16.0.0/12–24
192.168.0.0/16–24

So, we need change these hard code to some configuration, it can meet the user specific requirement flexiblly.

Yikun Jiang (yikunkero)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/534721

Changed in tempest:
assignee: nobody → Yikun Jiang (yikunkero)
status: New → In Progress
Revision history for this message
Martin Kopec (mkopec) wrote :

Moving back to new due to a long inactivity. We should discuss what we wanna do with this.

Changed in tempest:
assignee: Yikun Jiang (yikunkero) → nobody
status: In Progress → New
Revision history for this message
Martin Kopec (mkopec) wrote :

Moving to Confirmed as the cidr is hardcoded in the code which is not ideal. There is a partial fix for the issue, mentioned above, however it's incomplete - although it removed the hardcoded values, it changed the nature of the tests (see the comments in the review) which is not a wanted outcome. I'll move this to Confirmed until someone picks this up.

Changed in tempest:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tempest (master)

Change abandoned by "Ghanshyam <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tempest/+/534721
Reason: There is no change/response since long, we are abandoning it feel free to restore an rebase it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tempest/+/877292

Changed in tempest:
status: Confirmed → In Progress
Revision history for this message
Pragadeeswaran Sathyanarayanan (psathyan) wrote :
Changed in tempest:
assignee: nobody → Pragadeeswaran Sathyanarayanan (psathyan)
status: In Progress → Confirmed
Changed in tempest:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.opendev.org/c/openstack/tempest/+/877292
Committed: https://opendev.org/openstack/tempest/commit/80851ad9061f289053b19030f72e05699a513160
Submitter: "Zuul (22348)"
Branch: master

commit 80851ad9061f289053b19030f72e05699a513160
Author: Pragadeeswaran Sathyanarayanan <email address hidden>
Date: Tue Mar 21 15:14:42 2023 +0530

    rm hardcoded cidr in test_create_server_multi_nic

    Now, We have some hard code in here, but some VPC are limited to
    some specific address ranges by default in some cloud.

    So, we need change these hard code to configuration, it can
    meet the user specific requirement flexibly and reasonably.

    closes-bug: #1743742
    Signed-off-by: Pragadeeswaran Sathyanarayanan <email address hidden>
    Change-Id: Ia201c0520b8d2df17664b84bd61755d7c2d68258

Changed in tempest:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tempest 34.2.0

This issue was fixed in the openstack/tempest 34.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.