tempest cleanup is broken for volume clients usage

[Ghanshyam Mann]

Volume service clients alias in client.py has been changed depends on available version of cinder.

- https://github.com/openstack/tempest/blob/master/tempest/clients.py#L221

Which makes tempest cleanup broken as it still using the old alias and get no attribute error:

Traceback (most recent call last):
  File "/opt/stack/tempest/tempest/cmd/cleanup.py", line 98, in take_action
    self._cleanup()
  File "/opt/stack/tempest/tempest/cmd/cleanup.py", line 153, in _cleanup
    self._clean_project(project)
  File "/opt/stack/tempest/tempest/cmd/cleanup.py", line 202, in _clean_project
    svc = service(mgr, **kwargs)
  File "/opt/stack/tempest/tempest/cmd/cleanup_service.py", line 144, in __init__
    self.client = manager.snapshots_client
AttributeError: 'Manager' object has no attribute 'snapshots_client'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/515253

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/515253
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=5992895eb16f73f65fabe25d535da95395b80bfe
Submitter: Zuul
Branch: master

commit 5992895eb16f73f65fabe25d535da95395b80bfe
Author: ghanshyam <email address hidden>
Date: Thu Oct 26 01:38:45 2017 +0000

    Fix 'tempest cleanup' for volume service client

    In below patch, volume service clients alias in cleint.py
    has been changed and out under version checks condition.
    - I1400a870de483f5cdf125eae2a9be68b46b54343

    But tempest cleanup cmd used the alias not present for all
    version and get no attribute error if volume v2 or v3 version
    is configured.

    Change-Id: I1d0d86417ce6d92bfa0ef450ceb70dd480978fe1
    Closes-Bug: #1727569

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 17.2.0 release.