Some network tests do not use preprovisioned networks

Bug #1708550 reported by Mathieu Gagné on 2017-08-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Undecided
Unassigned

Bug Description

Following test cases are not using the network resources available from pre-provisioned credentials:
* tempest.api.network.test_ports.PortsTestJSON [1]
* tempest.api.network.test_networks.NetworksTest [2]

[1] https://github.com/openstack/tempest/blob/16.1.0/tempest/api/network/test_ports.py#L43
[2] https://github.com/openstack/tempest/blob/16.1.0/tempest/api/network/test_networks.py#L36

Creating new ports should be possible using an existing network.

zhufl (zhu-fanglei) wrote :

Thanks for reporting this.
It's no harm for neutron testcases to create networks,
and we'd better do so to get a clean test environment.

Slawek Kaplonski (slaweq) wrote :

I agree that creating network "per test class" shouldn't be any problem in Neutron tests so IMHO this is not an issue at all (at least from neutron perspective).

Dr. Jens Harbott (j-harbott) wrote :

I disagree here, the idea of running tempest with pre-provisioned credential is also to use pre-defined networks only, in order to be able to restrict the effect of running these tests in a production environment. See also the description of this config option:

    cfg.BoolOpt('create_isolated_networks',
                default=True,
                help="If use_dynamic_credentials is set to True and Neutron "
                     "is enabled Tempest will try to create a usable network, "
                     "subnet, and router when needed for each project it "
                     "creates. However in some neutron configurations, like "
                     "with VLAN provider networks, this doesn't work. So if "
                     "set to False the isolated networks will not be created"),

For me this implies that with create_isolated_networks=False, all tests should either use the pre-defined network or be skipped.

Ghanshyam Mann (ghanshyammann) wrote :

I am re-analysing this bug from what I said during office hour[1]

There are two part of it when it comes to using the network from pre-provisioned credential.

1. Tests need a network to setup on the test created server for checking connectivity or booting the server.

2. Tests testing the network creation and other parts of network service like port, router etc independently.

In case of pre-provisioned cred,
Part 1 is where we need to use priority 1. network mentioned in pre-provisioned priority 2. network mentioned in CONF.compute.fixed_network_name . Tempest take care of this part here[2]. If any test falls under this category and we do not take care of the existing network then we need to fix those by using the existing network or skip those

Now come to part2 which is this bug for, those tests are testing the creation of the network and its subresources etc so we should not use pre-provisioned network or CONF.compute.fixed_network_name there. Test should create the network resources for which test is written to verify.

Another point to consider here is - whether test env want to create the network or not then, tester can avoid network only tests which comes under part-2.

So, this bug does not seem to be valid for me at least listed tests in the description.

[1]http://eavesdrop.openstack.org/meetings/qa/2018/qa.2018-12-06-09.11.log.html#l-91
[2] https://github.com/openstack/tempest/blob/9bb03a9782cf3a882ef4efb6545109d437b6e569/tempest/lib/common/fixed_network.py#L95-L104

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers