RemoteClient has bad default ssh_shell_prologue

Bug #1707478 reported by Kris Sterckx
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Undecided
Kris Sterckx

Bug Description

RemoteClient has a bad default ssh_shell_prologue, being
"set -eu -o pipefail; PATH=$$PATH:/sbin;"

https://github.com/openstack/tempest/blob/master/tempest/lib/common/utils/linux/remote_client.py#L70

The double $$ sign should be single $.

This breaks remote script execution, e.g. try submitting a simple "ls /etc" - it won't find ls.

Changed in tempest:
assignee: nobody → Kris Sterckx (krissterckx)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/488991

Changed in tempest:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/488991
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=d8152de0da08e1654e6d25deee408f45d8a8f2bd
Submitter: Jenkins
Branch: master

commit d8152de0da08e1654e6d25deee408f45d8a8f2bd
Author: Kris Stercxk <email address hidden>
Date: Sun Jul 30 09:44:12 2017 +0200

    Fix RemoteClient having bad default ssh_shell_prologue

    Change-Id: I0e73b8deedf4bf78481cdf09b863dc149a70e9be
    Closes-Bug: #1707478

Changed in tempest:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tempest 17.0.0

This issue was fixed in the openstack/tempest 17.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.