client_parameters in ServiceClients class is not honoured
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tempest |
Fix Released
|
Medium
|
Andrea Frittoli |
Bug Description
client_parameters has been designed as a way to pass parameters for the client to the ServiceClients class.
After the initial implementation, the client registry has been added, which is a singleton which stores all service clients specs and parameters, coming from both tempest and plugins.
The client registry allows for automatic registration of all clients and their parameters. If configuration is available, parameters will be push into the registry automatically.
When the registry part has been implemented, the client_parameters logic has been broken. Parameters are loaded and prepared correctly, but ultimately they are not used for registration, they are basically ignored.
This is not a problem for Tempest in the gate since the valid parameters come from config via the registry. However the interface in http://
There are a few of options:
- drop client_parameters for good - it was introduced as a workaround until the registry was available anyways. This would imply a backward incompatible change to the interface. Document that the way to pass parameters to clients is via the registry only.
- mark client_parameters as deprecated - this would imply that we let the bug around until the deprecation period is over. If people tries to use the deprecated interface it won't work.
- implement the logic to fix the bug (i.e. if client_parameters is supplied, use that to register the client, and ignore parameters from the registry). This means more logic, more test cases, for something not really used, but fixing the bug and not changing the interface.
Changed in tempest: | |
assignee: | nobody → Andrea Frittoli (andrea-frittoli) |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in tempest: | |
status: | Confirmed → In Progress |
The patch is https:/ /review. openstack. org/#/c/ 454886/