novnc test cant support nova-novncproxy on SSL

Bug #1677142 reported by HengHa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Medium
HengHa

Bug Description

tempest/api/compute/servers/test_novnc.py

The cases in this file will connect nova-novncproxy service only via non-ssl. If nova-novncproxy service runs on SSL which offers a HTTPS service, this case will fail.

Need to modify this case to also support testing a HTTPS nova-novncproxy service.

HengHa (2001xxj)
Changed in tempest:
assignee: nobody → HengHa (2001xxj)
Revision history for this message
Ghanshyam Mann (ghanshyammann) wrote :

yea seems like we did not wrap socket with ssl.

Test make socket request to novnc host with defined url on nova side - https://github.com/openstack/nova/blob/136ec8aff71a6df1883246c8119ee1ee50255164/nova/conf/vnc.py#L82

Changed in tempest:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/455319

Changed in tempest:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/455319
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=8eb9098418eb708ba090d00ae971276cd1a9f860
Submitter: Jenkins
Branch: master

commit 8eb9098418eb708ba090d00ae971276cd1a9f860
Author: xxj <email address hidden>
Date: Mon Apr 10 21:18:39 2017 +0800

    Support testing nova-novncproxy on SSL

    When the VNC url is https, wrap the socket client with SSL.
    If the VNC url is of http, use a regular socket client.

    Change-Id: I7e5d6ccb65293b89540f528cc84da6c0d8699fee
    Closes-Bug: #1677142

Changed in tempest:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tempest 16.1.0

This issue was fixed in the openstack/tempest 16.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.