Tempest plugin service client registration is duplicated with >1 plugin

[Matthew Treinish]

If you install >1 plugin in your python environment and at least 1 plugin registers service clients that use a config variable anywhere in that call path you will end up with an attempted double registration of the clients for that plugin. This is because the private tempest config class will also run the plugin __init__() which unconditionally calls the register service clients function.

This is being hit right now on the sahara-tests plugin:

http://paste.openstack.org/show/584255/

(I added debug stack traces right after the registry init in the plugin manager class)

[Matthew Treinish (treinish)]

These failures are non-fatal but we do log an exception on each plugin registered right now which is kinda confusing.

[Matthew Treinish (treinish)]

Someone related to this bug is:

https://review.openstack.org/#/c/381992/

Which just fixes the duplicate tracebacks on every plugin.

[Attila Fazekas (afazekas)]

https://review.openstack.org/#/c/443630

[Paras Babbar (pbabbar)]

I think the fix suggested by Attila Fazekas (afazekas) should have fixed this issue, Can we mark this as fixed if we are not facing this issue anymore?

Thanks

[Paras Babbar (pbabbar)]

Moved it to fixed as this patch suppose to have fixed this issue https://review.openstack.org/#/c/443630 and we have no longer sees anyone reporting this issue .

Thanks

Paras