Incorrect assert in test_routers._verify_gateway_port

[Kieran Spear]

_verify_gateway_port has the following code, which seems to be trying to assert that the fixed ip of the port on the router is allocated from an appropriate public subnet. Since it only takes the first subnet of the public network, this will always fail if the ip of the port is in a different subnet.

        public_net_body = self.admin_networks_client.show_network(
            CONF.network.public_network_id)
        public_subnet_id = public_net_body['network']['subnets'][0]
        self.assertIn(public_subnet_id,
                      map(lambda x: x['subnet_id'], fixed_ips))

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/371145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371145
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=c6cb1ec0e000ee5ebdc1fd0dea63716c6829a298
Submitter: Jenkins
Branch: master

commit c6cb1ec0e000ee5ebdc1fd0dea63716c6829a298
Author: Kieran Spear <email address hidden>
Date: Thu Sep 15 19:49:35 2016 +0200

    Fix assert for public networks with multiple subnets

    _verify_gateway_port() currently assumes that the fixed ip
    for the router gateway is allocated from the first subnet of
    the public network. This is not always the case if there
    are multiple subnets on the public network.

    Change-Id: Ib13ba4aaed42f62397c7db165e765e47d4d49232
    Closes-Bug: 1624057