Incorrect resource setUp in VolumesV2SnapshotTestJSON/VolumesV1SnapshotTestJSON

[Ivan Kolodyazhny]

Commit [1] introduce snapshots setUp for each test. But it's needed only for few of them.

It leads to gate-tempest-dsvm-full-bdd-nv job [2] failures in Cinder's gates

[1] https://github.com/openstack/tempest/commit/755c6ee99133ffe586d8290910dc286459339264
[2] http://logs.openstack.org/12/330212/1/check/gate-tempest-dsvm-full-bdd-nv/a20d659/console.html

[Matthew Treinish (treinish)]

This does not look like a tempest bug to me at all:

http://logs.openstack.org/12/330212/1/check/gate-tempest-dsvm-full-bdd-nv/a20d659/logs/screen-c-vol.txt.gz?level=TRACE#_2016-06-15_22_25_09_138

Stack traces in the service logs are never a good thing. I suspect this has more to do with that job configuration and less to do with the tests.

[Ivan Kolodyazhny (e0ne)]

Matthew, partially, you're right. But we can't change our configuration due to the infra limitations.

In any case, creation resources only for the few tests in test case setup is not a good test design. All tests passed before patch [1] was merged

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332066

[Jordan Pittier (jordan-pittier)]

`resource_setup` is called by `setUpClass`. So it's called once per test class, not once par test. This bug looks invalid to me.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332066
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=f93209bb523a9ee14770f5fd7f7ac2812046c039
Submitter: Jenkins
Branch: master

commit f93209bb523a9ee14770f5fd7f7ac2812046c039
Author: Oleksii Butenko <email address hidden>
Date: Tue Jun 21 13:32:34 2016 +0300

    Move test_snapshot_list_* tests to new file

    test_snapshot_list_param_* tests require two volume snapshots.
    Moving all *_list_* tests to new file will repair
    gate-tempest-dsvm-full-bdd-nv job.

    Closes-bug: #1593278

    Change-Id: I1cff2bd62a40659f291ec7b78dbe080686149e34