Test internal network connectivity doesn't test connectivity to other VMs in test_network_basic_ops

[Tong Liu]

In test_network_basic_ops.py, _check_network_internal_connectivity only checks the connectivity to the network port on the network. While the test case test_connectivity_between_vms_on_different_networks in this test module explicitly wants to check the connectivity between vms on different network. We should also test connectivity to compute ports on the network in internal network connectivity check.

Current code in check_network_internal_connectivity
        internal_ips = (p['fixed_ips'][0]['ip_address'] for p in
                        self._list_ports(tenant_id=server['tenant_id'],
                                         network_id=network.id)
                        if p['device_owner'].startswith('network'))

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/296895

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296895
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=589f3152691a9249d4122cc4b92ef929b0e5dc8a
Submitter: Zuul
Branch: master

commit 589f3152691a9249d4122cc4b92ef929b0e5dc8a
Author: Tong Liu <email address hidden>
Date: Thu Mar 24 05:56:40 2016 +0000

    Add network internal connectivity check to VMs

    In test_network_basic_ops.py, _check_network_internal_connectivity
    only checks the connectivity to the network port on the network.
    While test_connectivity_between_vms_on_different_networks test
    case in this test module explicitly wants to check the
    connectivity between vms on different network. Add network
    internal connectivty check to other VMs on the network.

    Change-Id: Iff8e0f2d5db1bf9bc5bf064a0d066835e8a4cdbc
    Fixes-Bug: #1561335