Remove SQL's datetime format inplace of integer timestamps

Bug #1513538 reported by Lance Bragstad
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Invalid
Undecided
Unassigned

Bug Description

Keystone's current schema uses SQL's DATETIME format. Depending on the version of SQL (before or after v5.6.4), it may or may not support sub-second accuracy/precision.

> A DATETIME or TIMESTAMP value can include a trailing fractional seconds part in up to microseconds (6 digits) precision. In particular, as of MySQL 5.6.4, any fractional part in a value inserted into a DATETIME or TIMESTAMP column is stored rather than discarded.

Source: https://dev.mysql.com/doc/refman/5.6/en/datetime.html

We should replace keystone's use of DATETIME with an integer timestamp. With integer timestamps we can support sub-second accuracy regardless of the version of SQL being used.

Tags: sql
Dolph Mathews (dolph)
description: updated
tags: added: sql
Dolph Mathews (dolph)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243742

Changed in keystone:
assignee: nobody → Lance Bragstad (lbragstad)
status: New → In Progress
Changed in keystone:
assignee: Lance Bragstad (lbragstad) → Adam Young (ayoung)
Changed in keystone:
assignee: Adam Young (ayoung) → Lance Bragstad (lbragstad)
Changed in keystone:
assignee: Lance Bragstad (lbragstad) → Boris Bobrov (bbobrov)
Revision history for this message
Boris Bobrov (bbobrov) wrote :

Silly launchpad doesn't let me assign it back to Lance, so I'm just removing assignee.

Changed in keystone:
assignee: Boris Bobrov (bbobrov) → nobody
Changed in keystone:
assignee: nobody → Lance Bragstad (lbragstad)
Revision history for this message
Lance Bragstad (lbragstad) wrote :

This topic was discussed at the Keystone Mitaka Midcycle in Austin and I don't think this applies anymore. This could be closed by - https://review.openstack.org/#/c/275497/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Lance Bragstad (<email address hidden>) on branch: master
Review: https://review.openstack.org/243742
Reason: According to conversations at the mid-cycle, we are going to abandon the pursuit of sub-second precision in keystone [0]. This would be an unnecessary migration causing operator pain without a justified reason.

[0] https://review.openstack.org/#/c/275497/

Revision history for this message
Steve Martinelli (stevemar) wrote :

Marking this as invalid since the change was abandoned by the bug originator. Thanks Lance :)

Changed in keystone:
assignee: Lance Bragstad (lbragstad) → nobody
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tempest 11.0.0

This issue was fixed in the openstack/tempest 11.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.