FloatingIP Status is being verified after the connectivity check or the SSH connection.

[Swaminathan Vasudevan]

The FloatingIP status is verified after checking for the check_public_network_connectivity in most of the test cases.

In some of the test cases the FloatingIP status is not verified before any network/ssh connection to the IP.

It should be checked before checking for connectivity.
This would provide detailed information on the test failure pattern if it is related to FloatingIP.

Fixing it on all places where it is either not ordered properly or not included would be very usefull for the people who are reading the test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160135

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160533

[OpenStack Infra (hudson-openstack)]

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: master
Review: https://review.openstack.org/160533

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160471
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=27d75f4550984cb8f5cc932e2ba1b45518f85aba
Submitter: Jenkins
Branch: master

commit 27d75f4550984cb8f5cc932e2ba1b45518f85aba
Author: Swaminathan Vasudevan <email address hidden>
Date: Mon Mar 2 11:41:43 2015 -0800

    Check Floating ip status before load balancer check

    This patch checks for the floating ip status before
    the load balancer check.
    This would make sure that the floating ip is in an
    active state before checking the connection to the
    load balancer vip.

    If there is an issue with the Floating IP that would
    be more evident from the error message.

    This would also give enough time for the floatingip
    to become active.

    Partial-Bug: #1426764
    Change-Id: Ic25d51b6d448b156df14d3eaf2e8c32e3ca61a07

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160135
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=dc8bcdba8f9bfb1fbb1795b4a244e2defc051d53
Submitter: Jenkins
Branch: master

commit dc8bcdba8f9bfb1fbb1795b4a244e2defc051d53
Author: Swaminathan Vasudevan <email address hidden>
Date: Sat Feb 28 12:47:21 2015 -0800

    Fix check for FloatingIP status before check connection

    This patch changes the order in which the floatingIP
    status is being checked in all the network_basic and
    network_advanced tests.

    The check for floatingip status should be done before
    your check for public network connectivity to the VM.

    This would give the real details for the test case if
    it was related to floatingip setup or something in the
    test environment.

    Change-Id: Ie606ba5194fe87047d553056ba0a82bcf8830ac0
    Partial-Bug: #1426764

[Attila Fazekas (afazekas)]

The floating ip status is not checked before ssh connection because it would allow service changes(nova) which actually does the FIP work when it read by the end user.

This checks maybe done at SSH connection failure, as post failure debug info.

[Jordan Pittier (jordan-pittier)]

@attila, could you also leave a comment on https://review.openstack.org/#/c/160517/7 ?

[Swaminathan Vasudevan (swaminathan-vasudevan)]

When floatingips are configured their state is down. The agent takes sometime to configure the floatingip and then updates the status of the floatingip.
so it would always be better to check connectivity after you the floatingip status is "ACTIVE".

[OpenStack Infra (hudson-openstack)]

Change abandoned by Swaminathan Vasudevan (<email address hidden>) on branch: master
Review: https://review.openstack.org/160502
Reason: it is not applicable for v6.

[Ken'ichi Ohmichi (oomichi)]

There was not any activity for this bug over 2 years, so it is nice to drop this from our queue.