scenario/manager.py create security_group failed for tenant other than the default admin and tenant

[alex kang]

instance of class NetworkScenarioTest() will create 2 project/tenant/users, admin and tenant.

<instance of NetworkScenarioTest>._create_security_group() can create
[1] security group - self._create_empty_security_group(namestart, client, tenant_id)
[2] loginable security group rule - self._create_loginable_secgroup_rule(secgroup)

The problem is on [2] as it did not pass the client to create security rule, if the client is the <instance of NetworkScenarioTest>.
The test will failed with:

BadRequest: Bad request
Details: {u'NeutronError': u"Specifying 'tenant_id' other than authenticated tenant in request requires admin privileges"}

we need to change:
    rules = self._create_loginable_secgroup_rule(secgroup=secgroup)
to
    rules = self._create_loginable_secgroup_rule(client=client, secgroup=secgroup)

so if I call self._create_security_group(client=self.alt_manager.network_client) the loginable rules can be created as the owner of the security rule is alt_manager, not either one of the default managers of NetworkScenarioTest.

[alex kang (akang)]

Correction: if the client is NOT either the NetworkScenarioTest's admin or tenant project.

[Ghanshyam Mann (ghanshyammann)]

Yes, that's issue. When using _create_security_group with other client than primary or admin it through error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/148806

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148806
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=38890b5facf0442d8992f4bec84b96387b4e8bd0
Submitter: Jenkins
Branch: master

commit 38890b5facf0442d8992f4bec84b96387b4e8bd0
Author: ghanshyam <email address hidden>
Date: Wed Jan 21 15:24:18 2015 +0900

    Fix _create_loginable_secgroup_rule in scenario manager

    In NetworkScenarioTest, _create_security_group does not pass the
    requested client to _create_loginable_secgroup_rule.

    If sec grp is being created with different client than admin or primary
    cred then, _create_loginable_secgroup_rule will through Bad Request.
    This is because sec grp is being created with different tenant and tests
    try to add rule with different tenant.

    This patch fix above issue.

    Closes-Bug: 1412303

    Change-Id: I558fec9081644b795f550ae4e63f133e22d6f325