tempest-lib migration script generates incorrect sha1s

Bug #1386782 reported by Matthew Treinish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
High
Mauro S M Rodrigues

Bug Description

The tempest-lib migrate_from_tempest.sh script which generates a list of commits that were part of the migration from tempest is generating incorrect sha1s for each commit. This is the script uses git filter-branch to generate the subset of history for the specific files being migrated. But in doing this the parent commits are being changed which results in a different sha1 then what is in the tempest git log.

This means that the sha1s used in the commit message for the tempest-lib migration commit will not match anything in the tempest git history.

For example from the current git log on tempest-lib one sample entry from a migration git commit message is:

ecaa61e Merge "Fail tempest if 0 tests are run"

However when you look at the commit history in tempest there is no commit matching the sha1 ecaa61e, and the sha1 for the commit matching that commit summary is: c6dac5315e909bfe5097f3b521efc68ded8847cb or shortened: c6dac53

The script will need to be modified to get the sha1s from the full git log instead of a filtered branch.

tags: added: low-hanging-fruit
Changed in tempest:
assignee: nobody → Mauro Sergio Martins Rodrigues (maurosr)
Revision history for this message
chandan kumar (chkumar246) wrote :

Hey Mauro,

Are you still working on this?
if not, can i take it?

Thanks,

Chandan Kumar

Revision history for this message
Mauro S M Rodrigues (maurorodrigues) wrote :

Hey Chandan, I will resume today if I can... if I don't have time today I will leave it to you to work on it tomorrow ok?
Thanks

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/139679

Changed in tempest:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest-lib (master)

Reviewed: https://review.openstack.org/139679
Committed: https://git.openstack.org/cgit/openstack/tempest-lib/commit/?id=c9c9ff674b4d3b9e11a0a7b5e3676bcf109f59ec
Submitter: Jenkins
Branch: master

commit c9c9ff674b4d3b9e11a0a7b5e3676bcf109f59ec
Author: Mauro S. M. Rodrigues <email address hidden>
Date: Fri Dec 5 14:23:32 2014 -0200

    Fix migration script to use original SHA1 from tempest's commits

    Use git log instead of git filter-branch - which rewrites the history - to get
    SHA1 from the commits that touch the files to be migrated from tempest to
    tempest_lib.

    Change-Id: I321d78390991eb90fbb4a176a12187b78edc9f31
    Closes-bug: #1386782

Changed in tempest:
status: In Progress → Fix Committed
Changed in tempest:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.