Docstrings for tempest scenario test 'sever basic operations' (test_server_basic_ops.py) is not fully appropriate

Bug #1353814 reported by Ankur Gupta
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Wishlist
Ghanshyam Mann

Bug Description

Tempest scenario test "sever basic operations" ("tempest/tempest/scenario/test_server_basic_ops.py")contains below docstrings(Line #31- #41)-

  """
    This smoke test case follows this basic set of operations:

     * Create a keypair for use in launching an instance
     * Create a security group to control network access in instance
     * Add simple permissive rules to the security group
     * Launch an instance
     * Pause/unpause the instance
     * Suspend/resume the instance
     * Terminate the instance
    """

In above docstrings it specifie the operations performed under test case "sever basic operations" but in actual implementation, it doesn't cover below mentioned operations-
* Pause/unpause the instance
* Suspend/resume the instance

In actual implementation, test case "server basic operations" cover below tests/operations only-
1. Create a keypair for use in launching an instance
2. Create a security group to control network access in instance
3. Launch an instance
4. Obtaining floating IP to Instance
5. Verify ssh to instance
6. Terminate the instance

So, docstrings need to be updated because it is inappropriate and anyone can mislead(assume that it is covering operations/tests " Pause/unpause the instance" and " Suspend/resume the instance" too while it doesn't).

JFYI-
Test case "Suspend/resume the instance" cover under scenario test "Server Advanced Operations" (test_server_advanced_ops.py).

summary: Operation specific comment inside tempest scenario test 'sever basic
- operations'(test_server_basic_ops.py) is not fully appropriate
+ operations' (test_server_basic_ops.py) is not fully appropriate
Changed in tempest:
assignee: nobody → Ankur Gupta (ankur-gupta-v)
summary: - Operation specific comment inside tempest scenario test 'sever basic
- operations' (test_server_basic_ops.py) is not fully appropriate
+ Docstrings inside tempest scenario test 'sever basic operations'
+ (test_server_basic_ops.py) is not fully appropriate
description: updated
summary: - Docstrings inside tempest scenario test 'sever basic operations'
+ Docstrings for tempest scenario test 'sever basic operations'
(test_server_basic_ops.py) is not fully appropriate
Changed in tempest:
assignee: Ankur Gupta (ankur-gupta-v) → nobody
Changed in tempest:
status: New → Confirmed
Changed in tempest:
status: Confirmed → New
Revision history for this message
Ghanshyam Mann (ghanshyammann) wrote :

Yes, doc string needs to be updated as those tests are covered in test_network_advanced_server_ops.py & test_server_advanced_ops.py

Changed in tempest:
status: New → Confirmed
importance: Undecided → Low
Changed in tempest:
assignee: nobody → Ankur Gupta (ankur-gupta-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/125549

Changed in tempest:
assignee: Ankur Gupta (ankur-gupta-v) → Ghanshyam Mann (ghanshyammann)
status: Confirmed → In Progress
Changed in tempest:
importance: Low → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/125549
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=416c94c948ed0ac50e7e68b5b04959621773e481
Submitter: Jenkins
Branch: master

commit 416c94c948ed0ac50e7e68b5b04959621773e481
Author: ghanshyam <email address hidden>
Date: Thu Oct 2 13:47:25 2014 +0900

    Fix Docstrings for test_server_basic_ops.py

    In commit I80d785bb5b325ccfac3c5cfd9d076718cf587e80,
    Pause/unpause & Suspend/resume tests have been moved from this
    test class but docstring was not updated.

    Closes-Bug: #1353814

    Change-Id: If890e459a9621e74df55d60d8befe53c471aa83f

Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.