Tempest attempts console dump on ERROR state

[Attila Fazekas]

http://logs.openstack.org/69/100469/1/check/check-tempest-dsvm-postgres-full/ed1c6cc/console.html

2014-06-17 11:27:44.266 | tempest.api.compute.security_groups.test_security_groups.SecurityGroupsTestXML.test_server_security_groups[gate,smoke]
2014-06-17 11:27:44.267 | ----------------------------------------------------------------------------------------------------------------------
2014-06-17 11:27:44.267 |
2014-06-17 11:27:44.267 | Captured traceback:
2014-06-17 11:27:44.267 | ~~~~~~~~~~~~~~~~~~~
2014-06-17 11:27:44.267 | Traceback (most recent call last):
2014-06-17 11:27:44.267 | File "tempest/api/compute/security_groups/test_security_groups.py", line 101, in test_server_security_groups
2014-06-17 11:27:44.267 | self.servers_client.wait_for_server_status(server_id, 'ACTIVE')
2014-06-17 11:27:44.267 | File "tempest/services/compute/xml/servers_client.py", line 390, in wait_for_server_status
2014-06-17 11:27:44.267 | raise_on_error=raise_on_error)
2014-06-17 11:27:44.267 | File "tempest/common/waiters.py", line 106, in wait_for_server_status
2014-06-17 11:27:44.267 | _console_dump(client, server_id)
2014-06-17 11:27:44.267 | File "tempest/common/waiters.py", line 27, in _console_dump
2014-06-17 11:27:44.268 | resp, output = client.get_console_output(server_id, None)
2014-06-17 11:27:44.268 | File "tempest/services/compute/xml/servers_client.py", line 598, in get_console_output
2014-06-17 11:27:44.268 | length=length)
2014-06-17 11:27:44.268 | File "tempest/services/compute/xml/servers_client.py", line 441, in action
2014-06-17 11:27:44.268 | resp, body = self.post("servers/%s/action" % server_id, str(doc))
2014-06-17 11:27:44.268 | File "tempest/common/rest_client.py", line 209, in post
2014-06-17 11:27:44.268 | return self.request('POST', url, extra_headers, headers, body)
2014-06-17 11:27:44.268 | File "tempest/common/rest_client.py", line 419, in request
2014-06-17 11:27:44.268 | resp, resp_body)
2014-06-17 11:27:44.268 | File "tempest/common/rest_client.py", line 468, in _error_checker
2014-06-17 11:27:44.268 | raise exceptions.BadRequest(resp_body)
2014-06-17 11:27:44.268 | BadRequest: Bad request
2014-06-17 11:27:44.269 | Details: {'message': 'The server could not comply with the request since it is either malformed or otherwise incorrect.', 'code': '400'}

The server booting to ERROR state does not have any interesting information on the console,
and the original exception needs to be risen instead of a confusing one.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/101415

[Ken'ichi Ohmichi (oomichi)]

This ticket is duplicated with https://bugs.launchpad.net/bugs/1329563
but this ticket seems better explanation because of the title.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/101415
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=0462a7f212882d8ca5dd974a80c9ff6f18b3fc69
Submitter: Jenkins
Branch: master

commit 0462a7f212882d8ca5dd974a80c9ff6f18b3fc69
Author: Attila Fazekas <email address hidden>
Date: Fri Jun 20 07:38:06 2014 +0200

    Replace the console output on Error with fault a message

    Trying to get the console log from an ERROR-ed server
    does not really works

    The console log does not contains any meaningful info
    related to most status changes,
    it is just what the instance prints to the serial console.

    Only one action is guest assisted: the 'soft reboot',
    which automatically switched to 'hard reboot'
    when the guest forgets to assist
    (ie. does not shutdown in 120 sec)

    Testing the console output presence before reporting
    active state would make more sense.

    Instead of attempting to get the serial console output,
    after this change the response 'fault' field will be used
    for exception detail when available.

    Closes-Bug: #1332414

    This reverts commit c1a3bbe37c6202562fad5ff1be6e818d12797aee.

    Change-Id: I2018f98cdc4a1bc7dd8f34833df228dc56d88a95