Neutron VPN API test failing during VPN service creation

[Miguel Lavalle]

Module tempest.api.network.test_vpnaas_extensions is failing in the gate when executing when its setUpClass attempts to create a vpn service. The error is the following:

======================================================================
2013-12-09 12:32:53.781 | FAIL: setUpClass (tempest.api.network.test_vpnaas_extensions.VPNaaSJSON)
2013-12-09 12:32:53.781 | setUpClass (tempest.api.network.test_vpnaas_extensions.VPNaaSJSON)
2013-12-09 12:32:53.781 | ----------------------------------------------------------------------
2013-12-09 12:32:53.781 | _StringException: Traceback (most recent call last):
2013-12-09 12:32:53.782 | File "tempest/api/network/test_vpnaas_extensions.py", line 46, in setUpClass
2013-12-09 12:32:53.782 | cls.router['id'])
2013-12-09 12:32:53.782 | File "tempest/api/network/base.py", line 218, in create_vpnservice
2013-12-09 12:32:53.782 | name=data_utils.rand_name("vpnservice-"))
2013-12-09 12:32:53.782 | File "tempest/services/network/json/network_client.py", line 644, in create_vpn_service
2013-12-09 12:32:53.782 | resp, body = self.post(uri, headers=self.headers, body=body)
2013-12-09 12:32:53.782 | File "tempest/common/rest_client.py", line 302, in post
2013-12-09 12:32:53.783 | return self.request('POST', url, headers, body)
2013-12-09 12:32:53.783 | File "tempest/common/rest_client.py", line 436, in request
2013-12-09 12:32:53.783 | resp, resp_body)
2013-12-09 12:32:53.783 | File "tempest/common/rest_client.py", line 486, in _error_checker
2013-12-09 12:32:53.783 | raise exceptions.BadRequest(resp_body)
2013-12-09 12:32:53.783 | BadRequest: Bad request
2013-12-09 12:32:53.783 | Details: {u'NeutronError': {u'message': u'Router e20ef18b-b939-43b9-a24e-c63d718ddeb6 has no external network gateway set', u'type': u'RouterIsNotExternal', u'detail': u''}}

Since prior to create the vpn service, this test also creates a network (that is not deleted), a cascade of failures in the gate is triggered, with several tests failing with the following error:

2013-12-09 12:32:53.786 | BadRequest: Bad request
2013-12-09 12:32:53.787 | Details: {u'badRequest': {u'message': u'Multiple possible networks found, use a Network ID to be more specific.', u'code': 400}}

[Nachi Ueno (nati-ueno)]

In order to use VPN, the router should be set external gateway.

We should that configuration in here.
https://github.com/openstack/tempest/blob/master/tempest/api/network/test_vpnaas_extensions.py#L43

[Nachi Ueno (nati-ueno)]

Here is the code which setups external gateway
https://github.com/openstack/tempest/blob/master/tempest/api/network/test_routers.py#L61

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/61234

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/61234
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=41ecf5b3d511b631cdb8061ee325a6abaed69d88
Submitter: Jenkins
Branch: master

commit 41ecf5b3d511b631cdb8061ee325a6abaed69d88
Author: Nachi Ueno <email address hidden>
Date: Tue Dec 10 13:26:33 2013 -0800

    Fix Neutron VPNaaS Test

    VPNService requires Router is connected to external gateway.
    In this commit, we connected the test router to external network.

    Change-Id: Ib87583219efd8efd959c9c7edb813c3a70e7d20c
    Closes-Bug:1259282