Bug #1226374 " misused assertTrue in unit tests” : Bugs : tempest

OpenStack Infra (hudson-openstack) on 2013-09-17

Changed in tempest:
assignee:	nobody → ChangBo Guo (guochbo)
status:	New → In Progress
Changed in keystone:
assignee:	nobody → ChangBo Guo (guochbo)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-17: Fix proposed to glance (master)

#1

Fix proposed to branch: master
Review: https://review.openstack.org/46868

Changed in glance:
assignee:	nobody → ChangBo Guo (guochbo)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-17: Fix proposed to heat (master)

#2

Fix proposed to branch: master
Review: https://review.openstack.org/46906

Changed in heat:
assignee:	nobody → ChangBo Guo (guochbo)
status:	New → In Progress

Steven Hardy (shardy) on 2013-09-17

Changed in heat:
milestone:	none → havana-rc1
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-17: Fix merged to heat (master)

#3

Reviewed: https://review.openstack.org/46906
Committed: http://github.com/openstack/heat/commit/c8b142182f38fa0d1752a9f02361e30413d9ccf2
Submitter: Jenkins
Branch: master

commit c8b142182f38fa0d1752a9f02361e30413d9ccf2
Author: Chang Bo Guo <email address hidden>
Date: Tue Sep 17 02:02:50 2013 -0700

Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: I6826fefbb7c6fed8b0e664da36b144e882fb6d0e

Changed in heat:
status:	In Progress → Fix Committed

Revision history for this message

Dolph Mathews (dolph) wrote on 2013-09-17:

#4

Found at least one instance of this in python-keystoneclient as well

Changed in python-keystoneclient:
status:	New → Triaged
milestone:	none → 0.3.3
Changed in keystone:
milestone:	none → havana-rc1

Revision history for this message

Dolph Mathews (dolph) wrote on 2013-09-17:

#5

There may be more, but here's the few examples I came across:

keystone/tests/test_middleware.py:152: self.assertTrue(req.content_type, 'application/json')
keystone/tests/test_v3_oauth1.py:150: self.assertTrue(resp.result.get('consumer').get('id'), consumer_id)
keystone/tests/test_v3_oauth1.py:272: self.assertTrue(entity['id'], self.access_token.key)
keystone/tests/test_v3_oauth1.py:273: self.assertTrue(entity['consumer_id'], self.consumer.key)
keystone/tests/test_v3_oauth1.py:297: self.assertTrue(entity['id'], self.role_id)

tests/v2_0/test_ec2.py:148: self.assertTrue(len(creds), 2)

ChangBo Guo(gcb) (glongwave) on 2013-09-17

Changed in python-keystoneclient:
assignee:	nobody → ChangBo Guo (guochbo)

Revision history for this message

ChangBo Guo(gcb) (glongwave) wrote on 2013-09-17:

#6

Dolph ,

This is patch for keystone https://review.openstack.org/#/c/46855/

I will check again . and submit a patch for python-keystoneclient include "tests/v2_0/test_ec2.py:148: self.assertTrue(len(creds), 2)" .

thanks.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-17: Fix proposed to python-keystoneclient (master)

#7

Fix proposed to branch: master
Review: https://review.openstack.org/46975

Changed in python-keystoneclient:
status:	Triaged → In Progress

Dolph Mathews (dolph) on 2013-09-17

Changed in python-keystoneclient:
importance:	Undecided → Low
Changed in keystone:
importance:	Undecided → Low

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-17: Fix merged to keystone (master)

#8

Reviewed: https://review.openstack.org/46855
Committed: http://github.com/openstack/keystone/commit/e72c273d46a8c010baea70211800153b90c458ab
Submitter: Jenkins
Branch: master

commit e72c273d46a8c010baea70211800153b90c458ab
Author: Chang Bo Guo <email address hidden>
Date: Mon Sep 16 18:15:03 2013 -0700

Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: Ie034536127b13653040e2beaa7247c2ecd13f4f0

Changed in keystone:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-18: Fix proposed to ironic (master)

#9

Fix proposed to branch: master
Review: https://review.openstack.org/47072

Changed in ironic:
assignee:	nobody → ChangBo Guo (guochbo)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-18: Fix proposed to oslo-incubator (master)

#10

Fix proposed to branch: master
Review: https://review.openstack.org/47073

Changed in oslo:
assignee:	nobody → ChangBo Guo (guochbo)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-18: Fix proposed to melange (master)

#11

Fix proposed to branch: master
Review: https://review.openstack.org/47074

Changed in melange:
assignee:	nobody → ChangBo Guo (guochbo)
status:	New → In Progress

ChangBo Guo(gcb) (glongwave) on 2013-09-18

no longer affects:

melange

ChangBo Guo(gcb) (glongwave) on 2013-09-18

no longer affects:

neutron

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-18: Fix merged to oslo-incubator (master)

#12

Reviewed: https://review.openstack.org/47073
Committed: http://github.com/openstack/oslo-incubator/commit/6703c5cc744b183fea69cef42d03d4d3498cd22c
Submitter: Jenkins
Branch: master

commit 6703c5cc744b183fea69cef42d03d4d3498cd22c
Author: Chang Bo Guo <email address hidden>
Date: Tue Sep 17 19:55:35 2013 -0700

Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: I87308eb7871a55ef0fc49ca466311ed202b62d47

Changed in oslo:
status:	In Progress → Fix Committed

ZhiQiang Fan (aji-zqfan) on 2013-09-18

Changed in cinder:
assignee:	nobody → ZhiQiang Fan (aji-zqfan)
no longer affects:	cinder

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-19: Fix merged to ironic (master)

#13

Reviewed: https://review.openstack.org/47072
Committed: http://github.com/openstack/ironic/commit/190a0cce25ca9395b58a07512558bdab22207d61
Submitter: Jenkins
Branch: master

commit 190a0cce25ca9395b58a07512558bdab22207d61
Author: Chang Bo Guo <email address hidden>
Date: Tue Sep 17 19:17:29 2013 -0700

Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: I6ba14f94d49e071c4d2208f946befca915c83d53

Changed in ironic:
status:	In Progress → Fix Committed

Revision history for this message

ZhiQiang Fan (aji-zqfan) wrote on 2013-09-20:

#14

@Chang Bo Guo
swift:
test/unit/common/test_utils.py:1620 self.assertTrue(iter_file.closed, True)
test/unit/common/test_utils.py:1627 self.assertTrue(iter_file.closed, True)

i think the two lines are not correct too, since the second is a msg, True can be printed too ('True'), but makes no sense here

what's your opinion?

can i fix this? i'm glad to help

Revision history for this message

ChangBo Guo(gcb) (glongwave) wrote on 2013-09-20:

#15

@ZhiQiang ,
go ahead , thanks a lot :)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-20: Fix merged to tempest (master)

#16

Reviewed: https://review.openstack.org/46853
Committed: http://github.com/openstack/tempest/commit/4ae51d4133696c6bdf1acde1244f544e40804538
Submitter: Jenkins
Branch: master

commit 4ae51d4133696c6bdf1acde1244f544e40804538
Author: Chang Bo Guo <email address hidden>
Date: Mon Sep 16 18:01:39 2013 -0700

Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: I6ee1e3671054c4604ebb38ca9ceb52e8aef28540

Changed in tempest:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-20: Fix proposed to swift (master)

#17

Fix proposed to branch: master
Review: https://review.openstack.org/47600

Changed in swift:
assignee:	nobody → ZhiQiang Fan (aji-zqfan)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-20: Fix merged to swift (master)

#18

Reviewed: https://review.openstack.org/47600
Committed: http://github.com/openstack/swift/commit/92ae497800d9e66795346019cf284026a751597e
Submitter: Jenkins
Branch: master

commit 92ae497800d9e66795346019cf284026a751597e
Author: ZhiQiang Fan <email address hidden>
Date: Fri Sep 20 23:34:06 2013 +0800

Fix unsuitable assertTrue

    assertTrue accepts a parameter msg which will be printed when
    assertion fails, usually msg is a str. This patch fixes unsuitable
    usage of assertTrue which set msg to bool type True.

Change-Id: I731f8ea553c935eba0e112ffded16f41a5ea86c0
Fixes-Bug: #1226374

Changed in swift:
status:	In Progress → Fix Committed

Avishay Traeger (avishay-il) on 2013-09-22

no longer affects:

cinder

aeva black (tenbrae) on 2013-09-23

Changed in ironic:
importance:	Undecided → Medium

Mark McLoughlin (markmc) on 2013-09-24

Changed in oslo:
importance:	Undecided → Low
importance:	Low → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-27: Fix merged to python-keystoneclient (master)

#19

Reviewed: https://review.openstack.org/46975
Committed: http://github.com/openstack/python-keystoneclient/commit/baa949017a42368ec1e92e49490086364befe5da
Submitter: Jenkins
Branch: master

commit baa949017a42368ec1e92e49490086364befe5da
Author: Chang Bo Guo <email address hidden>
Date: Tue Sep 17 08:41:51 2013 -0700

Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: I678b2e7fcc522c8776c7fc0a554c1fc229ab781e

Changed in python-keystoneclient:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-30: Fix proposed to swift (feature/ec)

#20

Fix proposed to branch: feature/ec
Review: https://review.openstack.org/48990

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-10-01: Fix merged to swift (feature/ec)

#22

Download full text (17.5 KiB)

Reviewed: https://review.openstack.org/48990
Committed: http://github.com/openstack/swift/commit/175a837befd57b520e28623f0d708d883c023532
Submitter: Jenkins
Branch: feature/ec

commit 4c4a8abaa500d0d3940d81a4eb5ac21215ddc07a
Author: Kun Huang <email address hidden>
Date: Fri Sep 27 15:25:53 2013 +0800

improve bulk document

    This a very small change which just tell users request url of bulk
    delete request. In original docstrings, it just states the request
    parameters, request body and request method but not request url.

Change-Id: I0bbc302a0e072910bb58e4814614d7f761433b10

commit df39602c41605c4c68a47c6532a466ccc1a6633d
Author: David Goetz <email address hidden>
Date: Thu Sep 12 07:38:23 2013 -0700

bulk delete bug with trailing whitespace

Change-Id: Ia48224a1a187a8ed6b0c9a3c72cac06f084a6fc8

commit d8e0492ea80adae990f35930465d6e905a3be061
Author: Samuel Merritt <email address hidden>
Date: Tue Aug 27 18:00:04 2013 -0700

Fix internal swift.source tracking.

    In 1.8.0 (Grizzly), your proxy logs would indicate which middleware
    was responsible for an internal request, e.g. TU for tempurl or BD for
    bulk delete. At some point, those all turned into GET_INFO, which does
    not give you any idea which specific middleware was responsible, only
    that it came from a get_account_info/get_container_info call.

    This commit puts it back to how it was in 1.8.0. Also, the
    new-since-1.8.0 function get_object_info() got swift_source plumbing
    added to it, so source tracking for the quota middlewares'
    get_object_info() calls will happen now too.

    Note that due to the new-since-1.8.0 in-environment caching of
    account/container info, you may not see as many lines in the proxy log
    as you would with 1.8.0. This is because there are actually fewer
    internal requests being made.

Change-Id: I2b2ff7823c612dc7ed7f268da979c4500bbbe911

commit d9d7b2135a7020cdf43172ea4fcf0b1020f49101
Author: Samuel Merritt <email address hidden>
Date: Tue Sep 24 16:43:33 2013 -0700

Install libffi-dev in SAIO docs.

    If you don't, then newer versions of xattr won't install, and since
    our xattr requirement is simply ">= 0.4" in requirements.txt, this
    affects anyone setting up a new SAIO.

This happened with xattr 0.7, which was released on 2013-07-19.

Change-Id: Iaf335fa25a2908953d1fd218158ebedf5d01cc27

commit ce5e810fed8c453f4cd41c3c32162f47cde48f10
Author: Samuel Merritt <email address hidden>
Date: Tue Sep 24 16:20:28 2013 -0700

Update SAIO doc to have double proxy-logging in pipeline.

Change-Id: I0a034ca1420761cbf4e35dcea1d9cd18a92f90bd

commit 3e6f9293b8882cecb151e87fe5bfbe24e605b847
Author: Brian D. Burns <email address hidden>
Date: Thu Aug 1 14:50:03 2013 -0400

update SLO delete error handling

    * ensure all responses are 200 OK
    * report missing sub-SLO manifests or other error messages in bulk
      delete response

Change-Id: Iaf88c94bc7114ff3c9751f9f31f8f748de911f8a

commit 92ae497800d9e66795346019cf284026a751597e
Author: ZhiQiang Fan <email address hidden>
Date: Fri Sep 20 23:34:06 201...

Reviewed:  https://review.openstack.org/48990
Committed: http://github.com/openstack/swift/commit/175a837befd57b520e28623f0d708d883c023532
Submitter: Jenkins
Branch:    feature/ec

commit 4c4a8abaa500d0d3940d81a4eb5ac21215ddc07a
Author: Kun Huang <academicgareth@gmail.com>
Date:   Fri Sep 27 15:25:53 2013 +0800

improve bulk document
    
    This a very small change which just tell users request url of bulk
    delete request. In original docstrings, it just states the request
    parameters, request body and request method but not request url.
    
    Change-Id: I0bbc302a0e072910bb58e4814614d7f761433b10

commit df39602c41605c4c68a47c6532a466ccc1a6633d
Author: David Goetz <dpgoetz@gmail.com>
Date:   Thu Sep 12 07:38:23 2013 -0700

bulk delete bug with trailing whitespace
    
    Change-Id: Ia48224a1a187a8ed6b0c9a3c72cac06f084a6fc8

commit d8e0492ea80adae990f35930465d6e905a3be061
Author: Samuel Merritt <sam@swiftstack.com>
Date:   Tue Aug 27 18:00:04 2013 -0700

Fix internal swift.source tracking.
    
    In 1.8.0 (Grizzly), your proxy logs would indicate which middleware
    was responsible for an internal request, e.g. TU for tempurl or BD for
    bulk delete. At some point, those all turned into GET_INFO, which does
    not give you any idea which specific middleware was responsible, only
    that it came from a get_account_info/get_container_info call.
    
    This commit puts it back to how it was in 1.8.0. Also, the
    new-since-1.8.0 function get_object_info() got swift_source plumbing
    added to it, so source tracking for the quota middlewares'
    get_object_info() calls will happen now too.
    
    Note that due to the new-since-1.8.0 in-environment caching of
    account/container info, you may not see as many lines in the proxy log
    as you would with 1.8.0. This is because there are actually fewer
    internal requests being made.
    
    Change-Id: I2b2ff7823c612dc7ed7f268da979c4500bbbe911

commit d9d7b2135a7020cdf43172ea4fcf0b1020f49101
Author: Samuel Merritt <sam@swiftstack.com>
Date:   Tue Sep 24 16:43:33 2013 -0700

Install libffi-dev in SAIO docs.
    
    If you don't, then newer versions of xattr won't install, and since
    our xattr requirement is simply ">= 0.4" in requirements.txt, this
    affects anyone setting up a new SAIO.
    
    This happened with xattr 0.7, which was released on 2013-07-19.
    
    Change-Id: Iaf335fa25a2908953d1fd218158ebedf5d01cc27

commit ce5e810fed8c453f4cd41c3c32162f47cde48f10
Author: Samuel Merritt <sam@swiftstack.com>
Date:   Tue Sep 24 16:20:28 2013 -0700

Update SAIO doc to have double proxy-logging in pipeline.
    
    Change-Id: I0a034ca1420761cbf4e35dcea1d9cd18a92f90bd

commit 3e6f9293b8882cecb151e87fe5bfbe24e605b847
Author: Brian D. Burns <iosctr@gmail.com>
Date:   Thu Aug 1 14:50:03 2013 -0400

update SLO delete error handling
    
    * ensure all responses are 200 OK
    * report missing sub-SLO manifests or other error messages in bulk
      delete response
    
    Change-Id: Iaf88c94bc7114ff3c9751f9f31f8f748de911f8a

commit 92ae497800d9e66795346019cf284026a751597e
Author: ZhiQiang Fan <aji.zqfan@gmail.com>
Date:   Fri Sep 20 23:34:06 2013 +0800

Fix unsuitable assertTrue
    
    assertTrue accepts a parameter msg which will be printed when
    assertion fails, usually msg is a str. This patch fixes unsuitable
    usage of assertTrue which set msg to bool type True.
    
    Change-Id: I731f8ea553c935eba0e112ffded16f41a5ea86c0
    Fixes-Bug: #1226374

commit 01f58d68262aab1ac63683c9fac91b4da764aa92
Author: David Goetz <dpgoetz@gmail.com>
Date:   Tue Sep 10 09:01:32 2013 -0700

SLOs broken for range requests
    
    Change-Id: I21175a4be0cda9a8a98c425bff11c80895cd6d3e

commit 4a5c2fa0c6865f8a6dde2cd08ceb08c31ae38fa9
Author: gholt <z-launchpad@brim.net>
Date:   Thu Sep 19 21:05:46 2013 +0000

Log x-copy-from when it could be useful
    
    Change-Id: Ia28a9b47213f848ab5ea59572e14ac710ed881e3

commit 285a3a88a1ede50014d4f4a124994a2a0e85705b
Author: Greg Lange <greglange@gmail.com>
Date:   Tue Sep 17 19:24:24 2013 +0000

add seek() to CompressingFileReader
    
    Change-Id: I33d9119684497b53101db3bc380953e86bdf25f0

commit 58efcb3b3e70ba0502504124a1348ee14cc2687c
Author: gholt <z-launchpad@brim.net>
Date:   Thu Sep 19 17:14:35 2013 +0000

Fix probe tests
    
    Change-Id: I03573bf24baf031b1874c3ff2e2d89d34473c266

commit a6443f7068cdeaeb680f92849241be042fdc561d
Author: Prashanth Pai <ppai@redhat.com>
Date:   Tue Sep 17 12:24:29 2013 +0530

Add HTTPSeeOther(303) and HTTPTemporaryRedirect(307) to swob
    
    RFC 1945 and RFC 2068 specify that the client is not allowed to change the
    method on the redirected request.  However, most existing user agent
    implementations treat 302 as if it were a 303 response, performing a GET on
    the Location field-value regardless of the original request method. The status
    codes 303 and 307 have been added for servers that wish to make unambiguously
    clear which kind of reaction is expected of the client.
    
    HTTP/1.1 RFC for 302: http://tools.ietf.org/html/rfc2616#section-10.3.4
    HTTP/1.1 RFC for 307: http://tools.ietf.org/html/rfc2616#section-10.3.8
    
    Change-Id: I354e2f4f3e3eb6a1553b3d9c60b613d8f0c37531
    Signed-off-by: Prashanth Pai <ppai@redhat.com>

commit 7760f41c3ce436cb23b4b8425db3749a3da33d32
Author: Peter Portante <peter.portante@redhat.com>
Date:   Thu Sep 12 15:57:56 2013 -0400

Refactor common/utils methods to common/ondisk
    
    Place all the methods related to on-disk layout and / or configuration
    into a new common module that can be shared by the various modules
    using the same on-disk layout.
    
    Change-Id: I27ffd4665d5115ffdde649c48a4d18e12017e6a9
    Signed-off-by: Peter Portante <peter.portante@redhat.com>

commit da78035043643d1d89efbab197803d84934e420a
Author: Jamie Lennox <jlennox@redhat.com>
Date:   Tue Sep 17 11:46:04 2013 +1000

Add a user variable to templates
    
    This is a common configuration option and allows devstack (and others)
    to configure a mod_wsgi user to run the daemon process.
    
    Change-Id: Idf134b3bc6b08e3c3a80dde8830d5a4f3da5a06c
    Fixes: bug 1226346

commit 75086a13301f20a1f459cf2dbd684bc8a06726bb
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date:   Sat Sep 14 16:09:53 2013 -0600

Supply correct arguments to __init__ of a base class
    
    Hopefuly this extra test case is not too inane and slows us
    down for nothing. It is verified to fail with the old code.
    
    Change-Id: I604eca09f7f9ae044a8ad75284cd82a37325f99c

commit a9c119d440c99440088012417f56b1fa9baab980
Author: Alex Gaynor <alex.gaynor@gmail.com>
Date:   Fri Sep 13 15:38:01 2013 -0700

Removed many unnecessary uses of dict.keys
    
    This has a few advantages: some of these locations will perform
    slightly faster, it's minutely less code, and dict.keys has a different
    behavior on Python 3. Also removes usage of dict.iterkeys, which is
    identical to just iterating over the dict, except it doesn't exist on
    Python 3 at all.
    
    Change-Id: Ia91e97232dc8d78cf63fa807de288fc25cf5425d

commit 9cd7c6c15514794afba5ac019823578aa7fe92a9
Author: Samuel Merritt <sam@swiftstack.com>
Date:   Fri Sep 13 13:26:41 2013 -0700

Optimizations to Ring.get_more_nodes()
    
    When we're looking for handoffs, we first try to span all the regions,
    then zones, then devices. However, the search loops would always go
    over a big subset of the ring, regardless of whether or not there was
    anything left to find.
    
    In particular, this would result in long runtimes for the first call
    to get_more_nodes() if you didn't have more regions than replicas, as
    the region-search loop would chew through a ton of devices and not
    find any (since there weren't any). Now we do a little arithmetic,
    think about the pigeonhole principle a little bit, and bail out when
    there's nothing left to find, rather than waiting until there's no
    space left to search.
    
    Similar changes were made for the different-zone and different-device
    search loops.
    
    On a 4800-device test ring (4 regions, 5 zones each, 20 node each, 12
    drives each), the time to get all handoffs dropped to about 5% of its
    previous value (a 95% improvement).
    
    More usefully, on a 1200-device test ring (same as above but only 1
    region), the time to get just the first 6 handoffs dropped to about
    0.01% of its original runtime, or a 10,000x speedup.
    
    Fixes bug 1225018.
    
    Change-Id: I4c77094186f0032a3e19a099a1a0e71b2ba06719

commit cfa4f9497d8903d340f05f8314f40c814e3dde1c
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date:   Fri Sep 13 13:55:10 2013 -0600

Use a local variable auditor_worker
    
    This patch is only a cleanup, but our code makes me rage every time
    I read it. In short, we have a class with a variable self.auditor,
    and we assign ObjectAuditor to it at some ties, AuditorWorker at
    other times. So, whenever there's a mismerge or whatever, you cannot
    tell if self.auditor.broker_class makes sense or not.
    
    Since all cases of using self.auditor as AuditorWorker are purely
    local, just evict it to a local variable auditor_worker. Leave
    self.auditor to represent ObjectAuditor, because it's used as
    a class variable in places.
    
    Change-Id: I811b80ac6c69a4daacfed7a5918bc0b15761d72e

commit 5026e4569115e7aef1d25ed5ab9adbd6c330f110
Author: Alex Gaynor <alex.gaynor@gmail.com>
Date:   Fri Sep 13 10:36:54 2013 -0700

Switched some relative imports to be absolute
    
    Implicit relative imports don't work on Python3, and are also prone to
    several different classes of errors.
    
    Change-Id: I7b62e9bfbe9c0b1fc9876413e3139fda019a4e57

commit 5b0788d37d61584ba4b8e9f5d729ff2c5474f66c
Author: Alex Gaynor <alex.gaynor@gmail.com>
Date:   Fri Sep 13 09:50:14 2013 -0700

Use an existing local var rather than doing alookup
    
    This should make ``Ring.get_more_nodes`` microscopically faster.
    
    Change-Id: Ibf0988fe0630ad94ac0c04040766d89ef86d1488

commit a30a7ced9cc7c6510bbca93529e62bcbc30bf7c0
Author: Chuck Thier <cthier@gmail.com>
Date:   Thu Aug 22 19:23:29 2013 +0000

Add handoffs_first and handoff_delete to obj-repl
    
    If handoffs_first is True, then the object replicator will give
    partitions that are not supposed to be on the node priority.
    
    If handoff_delete is set to a number (n), then it will delete a handoff
    partition if at least n replicas were successfully replicated
    
    Also fixed a couple of things in the object replicator unit tests and
    added some more
    
    DocImpact
    
    Change-Id: Icb9968953cf467be2a52046fb16f4b84eb5604e4

commit 0b949ebe90ebd4613105af0c0127949128c2ec3d
Author: Peter Portante <peter.portante@redhat.com>
Date:   Thu Sep 12 16:00:49 2013 -0400

Remove unused method iter_devices_partition
    
    Change-Id: I69a14bcb92490abd3ad1070799bf1580a2dcaa92
    Signed-off-by: Peter Portante <peter.portante@redhat.com>

commit a44307940432af93d52dab0a2701c7d6d91beeed
Author: Clay Gerrard <clay.gerrard@gmail.com>
Date:   Wed Sep 11 22:42:19 2013 -0700

Ensure audit tests don't cause unwanted errors
    
    Because the audit code catches all Exceptions, bugs in the code, like
    misspelled names, bad logic, can result in errors which don't cause
    exceptions that kill the unit tests.
    
    Change-Id: Idb8e3b00a49863ab920161a46edb61a5c47fffe2

commit 0afcc674cb698906f354d9e57f97378d37d9d0c0
Author: David Goetz <dpgoetz@gmail.com>
Date:   Thu Sep 12 08:07:59 2013 -0700

remove useless if from slo
    
    Change-Id: Id232c6973dcb55c19233b6d517770e58c2737ba0

commit 64430da593b40186251b3de08b5ae18dcffb062b
Author: Clay Gerrard <clay.gerrard@gmail.com>
Date:   Wed Sep 11 12:44:23 2013 -0700

fix race in test_wait on busy server
    
    fix bug 1224208
    
    Change-Id: I83c673a87c31214a7c54b6399ca53512885e6bc3

commit 2283c54d199be5d19a4ca5fce6d692b6df9619b6
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date:   Wed Sep 11 19:46:34 2013 -0600

Tinker with dockstrings in back-ends and related places
    
    Change-Id: If80509e2e19cec5d0b8c5cfccd15e6d893558de4

commit d3bd30da4191e576f4e7b78498979ffc8892eeb5
Author: Chmouel Boudjnah <chmouel@enovance.com>
Date:   Tue Aug 6 14:15:48 2013 +0200

Fix sync test when localhost on port 80 is binded
    
    - When localhost:80 was binding the tests was trying to connect into it.
    - To test you can simply run sudo python -m SimpleHTTPServer 80 which
      should show :
    
      1.0.0.127.in-addr.arpa - - [06/Aug/2013 14:10:42] code 501, message Unsupported method ('DELETE')
      1.0.0.127.in-addr.arpa - - [06/Aug/2013 14:10:42] "DELETE /a/c/o HTTP/1.1" 501 -
    
      (the test was passing since 501 would raise ClientException).
      mock delete_object in the fourth test to fix that
    - Refactor the code to use mock.patch as well.
    
    Closes-Bug: 1208802
    Change-Id: I5ddd4ac3a97879f51cf5883fcfc0fe0f0adaeff6

commit 2d0ceb1e50f08bc9059c4d8560a3827ed8259508
Author: Clark Boylan <clark.boylan@gmail.com>
Date:   Tue Sep 10 15:56:09 2013 -0700

Verbose functional test request failures.
    
    * test/__init__.py: Put safe_repr import/implementation here so that it
    is available to functional and unit tests.
    
    * test/functional/swift_test_client.py: When a request fails
    record why that request failed, how many requests failed, and what the
    request was when raising RequestError to aid in debugging. Makes use of
    safe_repr from test/__init__.py.
    
    * test/unit/common/test_constraints.py: Remove implementation of
    safe_repr and use the implementation in test/__init__.py.
    
    Change-Id: I6c957343fb4b8b95d3875fd5ca87b3cf28a5f47a

commit 83a6ec1683fa0824d82a889046132a7ac33463a8
Author: Tobias Stevenson <tstevenson@vbridges.com>
Date:   Tue Aug 27 16:03:58 2013 -0500

Man page lintian errors and warnings
    
    Used groff to recreate the errors. I believe all the issues
    except `binary-without-manpage` are solved. Would like
    confirmation from someone using Lintian.
    
    Closes-Bug: #1210114
    Change-Id: I533205c53efdb7cdf3645cc3e3dc487f9ee5640a

commit 84296aae924e21dd34e9b07505ba30b72aaf3422
Author: Fabien Boucher <fabien.boucher@enovance.com>
Date:   Wed Aug 21 14:57:16 2013 +0200

Improve unittest coverage of account reaper
    
    Add more unittests for account_reaper in order to
    improve code coverage.
    
    Fixes: bug #1210045
    Change-Id: I73490f80ac70b814a0abc490dc932f2a86fca703

commit d51e87342331ded54de5424d888d9d143b132a7e
Author: Clay Gerrard <clay.gerrard@gmail.com>
Date:   Fri Aug 30 18:08:24 2013 -0700

Remove keep_data_fp argument from DiskFile constructor
    
    All access to the data_file fp for DiskFile is moved after the new "open"
    method.  This prepares to move some additional smarts into DiskFile and reduce
    the surface area of the abstraction and the exposure of the underlying
    implementation in the object-server.
    
    Future work:
    
     * Consolidate put_metadata to DiskWriter
     * Add public "update_metdata" method to DiskFile
     * Create DiskReader class to gather all access of methods under "open"
    
    Change-Id: I4de2f265bf099a810c5f1c14b5278d89bd0b382d

commit d4b024ad7d64a854072517eef47b059c93bdfdd3
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
Date:   Tue Sep 10 13:30:28 2013 -0600

Split backends off swift/common/db.py
    
    The main purpose of this patch is to lay the groundwork for allowing
    the container and account servers to optionally use pluggable backend
    implementations. The backend.py files will eventually be the module
    where the backend APIs are defined via docstrings of this reference
    implementation. The swift/common/db.py module will remain an internal
    module used by the reference implementation.
    
    We have a raft of changes to docstrings staged for later, but this
    patch takes care to relocate ContainerBroker and AccountBroker into
    their new home intact.
    
    Change-Id: Ibab5c7605860ab768c8aa5a3161a705705689b04

commit fffc95c3ccb01333becc86e0cb4c67cf5edf9725
Author: Fabien Boucher <fabien.boucher@enovance.com>
Date:   Tue Jul 16 16:39:23 2013 +0200

Handle X-Copy-From header in account_quota mw
    
    Content length of the copied object
    is checked before allowing the copy
    request according to the account
    quota set by Reseller.
    
    Fixes: bug #1200271
    Change-Id: Ie4700f23466dd149ea5a497e6c72438cf52940fd

commit 30b1590c3cbf066eee7d2411379654ceccd0a723
Author: Peter Portante <peter.portante@redhat.com>
Date:   Tue Sep 3 23:08:14 2013 -0400

Assume ETag is always in the metadata
    
    Currently the GET and HEAD calls always assume that the ETag is
    present in the on-disk metadata, as they index the metadata dictionary
    directly for the value to fill in the proper response header (a
    KeyError would be thrown if missing and turn into a 503).
    
    The close code that handles quarantining checked to see if an ETag is
    present in the metadata before making the comparison. However, a close
    operation would never even be attempted if an ETag was not present,
    since the response headers are filled in before the object is read.
    
    Change-Id: I5032251414eceb38079d235504cc9e589dea5f3e
    Signed-off-by: Peter Portante <peter.portante@redhat.com>

commit 93ab856f6640a2322846a6861a4dbe1085294667
Author: Peter Portante <peter.portante@redhat.com>
Date:   Wed Sep 4 22:25:28 2013 -0400

Add support for POST commit coverage runs
    
    Modeled on how keystone does it.
    
    Change-Id: Idad4f854f1bfb915a48ff69988553810a76accc0
    Signed-off-by: Peter Portante <peter.portante@redhat.com>

Thierry Carrez (ttx) on 2013-10-02

Changed in oslo:
milestone:	none → havana-rc1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-10-02

Changed in keystone:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-10-03

Changed in heat:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-10-09

Changed in swift:
milestone:	none → 1.10.0-rc1
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-10-09: Fix merged to glance (master)

#24

Reviewed: https://review.openstack.org/46868
Committed: http://github.com/openstack/glance/commit/b040c1aecc989db14134f0a3843de3b4abe7ba8c
Submitter: Jenkins
Branch: master

commit b040c1aecc989db14134f0a3843de3b4abe7ba8c
Author: Chang Bo Guo <email address hidden>
Date: Mon Sep 16 20:41:24 2013 -0700

Fix misused assertTrue in unit tests

Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: Iac5117c7a8dd3769aa6e303c6830aad291d5a0f7

Changed in glance:
status:	In Progress → Fix Committed

Dolph Mathews (dolph) on 2013-10-09

Changed in python-keystoneclient:
milestone:	0.3.3 → 0.4.0

Dolph Mathews (dolph) on 2013-10-09

Changed in python-keystoneclient:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-10-17

Changed in oslo:
milestone:	havana-rc1 → 2013.2

Thierry Carrez (ttx) on 2013-10-17

Changed in heat:
milestone:	havana-rc1 → 2013.2

Thierry Carrez (ttx) on 2013-10-17

Changed in swift:
milestone:	1.10.0-rc1 → 1.10.0

Thierry Carrez (ttx) on 2013-10-17

Changed in keystone:
milestone:	havana-rc1 → 2013.2

Thierry Carrez (ttx) on 2013-12-04

Changed in glance:
milestone:	none → icehouse-1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2013-12-09

Changed in ironic:
milestone:	none → icehouse-1
status:	Fix Committed → Fix Released

Sean Dague (sdague) on 2013-12-12

Changed in tempest:
status:	Fix Committed → Fix Released
assignee:	ChangBo Guo (guochbo) → nobody

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-12: Fix proposed to heat (master)

#25

Fix proposed to branch: master
Review: https://review.openstack.org/61816

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-18: Fix merged to heat (master)

#26

Reviewed: https://review.openstack.org/61816
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=aa51f82c9d05ff581cd35cb476c7900a74a839b8
Submitter: Jenkins
Branch: master

commit aa51f82c9d05ff581cd35cb476c7900a74a839b8
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Fri Dec 13 13:07:41 2013 +0200

Fix misused assertTrue in unit tests

one additional case of misuse of assertTrue was found

Change-Id: If62f5800566921433fc098dbba0188f69fbb6eb1
Closes-Bug: #1226374

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-19: Fix proposed to heat (master)

#27

Fix proposed to branch: master
Review: https://review.openstack.org/63089

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-27: Fix merged to heat (master)

#28

Reviewed: https://review.openstack.org/63089
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=480289776ece24f25baae47952917269e6355a4b
Submitter: Jenkins
Branch: master

commit 480289776ece24f25baae47952917269e6355a4b
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Thu Dec 19 13:23:06 2013 +0200

Fix misused assertTrue in unit tests

The patch merged under review https://review.openstack.org/#/c/61816/3
still uses assertTrue instead of assertEqual.

This patch properly corrects this.

Change-Id: I09fd4b7355dd721b513febd0669cb1368b5cda19
Closes-Bug: #1226374

Thierry Carrez (ttx) on 2014-04-17

Changed in glance:
milestone:	icehouse-1 → 2014.1

Thierry Carrez (ttx) on 2014-04-17

Changed in ironic:
milestone:	icehouse-1 → 2014.1

tempest

misused assertTrue in unit tests

Bug Description

Other bug subscribers

Remote bug watches

	Status	Importance	Assigned to	Milestone
Glance	Fix Released	Undecided	ChangBo Guo(gcb)	Glance 2014.1 "icehouse"
Ironic	Fix Released	Medium	ChangBo Guo(gcb)	Ironic 2014.1 "icehouse"
OpenStack Heat	Fix Released	Medium	ChangBo Guo(gcb)	OpenStack Heat 2013.2 "havana"
OpenStack Identity (keystone)	Fix Released	Low	ChangBo Guo(gcb)	OpenStack Identity (keystone) 2013.2 "havana"
OpenStack Object Storage (swift)	Fix Released	Undecided	ZhiQiang Fan	OpenStack Object Storage (swift) 1.10.0 "havana"
oslo-incubator	Fix Released	Medium	ChangBo Guo(gcb)	oslo-incubator 2013.2 "havana"
python-keystoneclient	Fix Released	Low	ChangBo Guo(gcb)	python-keystoneclient 0.4.0
tempest	Fix Released	Undecided	Unassigned