create aggregate

[Xurong Yang]

Create aggregate fails when input metadata "availability_zone" length >255(models.py value = Column(String(255), nullable=False)),Exception is raised but record in DB is not rolled back.

[Jake Liu (jake-liu)]

Hi Frank, just did some test according to your test steps but did not reproduce this.

From my test you can see that once the length of metadata value exceeds 255, then the value will be truncated to 255 without exception, this seems to be a design behavior for database behavior.

Please show your comments if any. Thanks!

-- Jake

jake@jake1:~$ nova aggregate-set-metadata 2 availability_zone=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxcccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccdddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd
/usr/lib/python2.7/dist-packages/gobject/constants.py:24: Warning: g_boxed_type_register_static: assertion `g_type_from_name (name) == 0' failed
  import gobject._gobject
Aggregate 2 has been successfully updated.
+----+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Id | Name | Availability Zone | Hosts | Metadata |
+----+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| 2 | agg1 | xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc...

[David Ripton (dripton)]

It depends on the DB and how it's configured. PostgreSQL gives an error if you try to shove 256+ characters into a 255-character field. MySQL truncates by default, but can be configured to give an error.

We should do the truncation in our code so the behavior is consistent across DBs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/53789

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/79529

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/79529
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=11b9305e3f0dcff7f5f92863cfd3679fd7b6a6a3
Submitter: Jenkins
Branch: master

commit 11b9305e3f0dcff7f5f92863cfd3679fd7b6a6a3
Author: wingwj <email address hidden>
Date: Tue Mar 11 11:38:14 2014 +0800

    Check the length of aggregate metadata

    PostgreSQL gives an error if you try to shove 256+ characters
    into a 255-character field. So we need raise a HTTPBadRequest
    explanation if the length of aggregate_metadata.keys or
    aggregate_metadata.values is above 255.

    Change-Id: I2c778f2237ba5bd2aa8335a0eae80f3aad3e9157
    Closes-Bug: #1219693