list_snapshots{_with_details} from xml/snapshots_client.py seems to be broken

Bug #1177610 reported by Giulio Fidente on 2013-05-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Medium
Giulio Fidente

Bug Description

the methods list_snapshots and list_snapshots_with_details from services/volume/xml/snapshots_client.py do not return a list of snaps but a string

tags: added: volume
tags: added: xml
Sean Dague (sdague) wrote :

can you explain how this is different from the json returns? and is there a test that is getting skipped because of this?

Changed in tempest:
status: New → Incomplete
Changed in tempest:
milestone: none → havana-3
assignee: nobody → Giulio Fidente (gfidente)
importance: Undecided → Medium
tags: removed: volume xml
Giulio Fidente (gfidente) wrote :

the test test_snapshot_create_get_list_delete goes in error when executed against the XML interface with:

_StringException: Traceback (most recent call last):
  File "/home/gfidente/Devel/github.com/tempest/tempest/api/volume/test_volumes_snapshots.py", line 60, in test_snapshot_create_get_list_delete
    snaps_data = [(f['id'], f['display_name']) for f in snaps_list]
TypeError: string indices must be integers, not str

where snaps_data comes from:
resp, snaps_list = self.snapshots_client.list_snapshots()

Fix proposed to branch: master
Review: https://review.openstack.org/31999

Changed in tempest:
status: Incomplete → In Progress
Changed in tempest:
milestone: havana-3 → havana-2

Reviewed: https://review.openstack.org/31999
Committed: http://github.com/openstack/tempest/commit/e92956b7dc64f837de4f22750f85cf912e3163eb
Submitter: Jenkins
Branch: master

commit e92956b7dc64f837de4f22750f85cf912e3163eb
Author: Giulio Fidente <email address hidden>
Date: Thu Jun 6 18:38:48 2013 +0200

    Fixes list_snapshots and _with_details methods in snap XML client

    Listing was not stripping outer 'snapshots' tag before return

    Change-Id: Ic95ed3b9f3f5c164f191c2445be611db2135ca54
    Fixes: bug #1177610

Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers