Delete a flavor test fails

[Jay Pipes]

Repeatedly seeing this on the gate-tempest-devstack-vm Jenkins CI job:

00:45:49 ======================================================================
00:45:49 FAIL: Delete a flavor and ensure it is not listed
00:45:49 ----------------------------------------------------------------------
00:45:49 Traceback (most recent call last):
00:45:49 File "/home/jenkins/workspace/gate-tempest-devstack-vm/tempest/tempest/tests/compute/admin/test_flavors.py", line 111, in test_get_flavor_details_for_deleted_flavor
00:45:49 self.admin_client.get_flavor_details, self.new_flavor_id)
00:45:49 AssertionError: NotFound not raised

[Dan Prince (dan-prince)]

Git commit 31506c0a252f06e283eecc54741f6a3062fbe913 today made some changes to instance types so that deleted 'flavors' (instances types) can still be queried via joins to instances.

See this ticket for details on that change: https://bugs.launchpad.net/nova/+bug/994935

Part of that commit looks Okay (the change to the InstanceTypes model). The change to get_instance_type_by_flavor_id is suspicious since that call is used via the flavors API directly to show flavors (to admins and non-admins) alike.

This appears to be a valid test failure.... If I understand this correctly we just need to revert the change to get_instance_type_by_flavor_id and we should be fine.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/7735

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/7735
Committed: http://github.com/openstack/nova/commit/f6e62c6120453fa90e2e690753fe6eaf157f2dde
Submitter: Jenkins
Branch: master

commit f6e62c6120453fa90e2e690753fe6eaf157f2dde
Author: Dan Prince <email address hidden>
Date: Wed May 23 23:06:22 2012 -0400

    API users should not see deleted flavors.

    Reverts a change earlier today to instance_types.get_instance_type_by_flavor_id
    which allows deleted flavors (instance types) to be displayed via the flavors
    API.

    Fixes LP Bug #1003741.

    Change-Id: I8236a2ca2a7b461a66c1118e599d5e49f2b650d8