Bad translation strings in code
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Telegram app |
Fix Released
|
High
|
Unassigned |
Bug Description
There are some bad translations and I wanted to fix them, but turns out, it's actually a problem in the code:
Example: %1 added %2
This string is used for someone else adding someone to a group, but also if the user of the app adds someone to a group. In German this is translated to:
%1 hat %2 hinzugefügt
This is fine in the case of
John added Frank -> John hat Frank hinzugefügt
However, in the case of the user himself performing this action it ends up being
You added John -> Sie hat John hinzugefügt
This however translates back to english as "She added John" and instead should be "%1 haben %2 hinzugefügt"
Basically the string needs to be split up into other people's actions and this user's actions.
Same goes for "%1 created %2". Not sure if there are more of them, but those happen frequently in the ui.
Related branches
- Michael Zanetti: Approve
- libqtelegram team: Pending requested
-
Diff: 163 lines (+108/-19)2 files modifieddiff (+64/-0)
telegram/app/qml/AccountMessageAction.qml (+44/-19)
description: | updated |
Changed in telegram-app: | |
importance: | Undecided → High |
tags: | added: i18n |
Changed in telegram-app: | |
assignee: | nobody → Jin (jin.cth) |
Changed in telegram-app: | |
status: | Confirmed → In Progress |
Changed in telegram-app: | |
status: | Fix Committed → Fix Released |
assignee: | Jin (jin.cth) → nobody |
Thanks. Even better, self actions should not be "You removed karni" but "You left the chat", etc.